View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010059VTK(No Category)public2009-12-16 22:202013-04-05 19:57
Reporterhfxt 
Assigned ToFrançois Bertel 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0010059: vtk 5.5 ; dead loop
Descriptionwhen comparing two float number,it should not use "==";

VTK\Common\vtkAbstractTransform.cxx
Line 534
Line 553
Line 605
VTK\Common\vtkBox.cxx
Line 46
Line 73
Line 88
..........

many places found.
TagsNo tags attached.
Project
Type
Attached Files

 Relationships

  Notes
(0018997)
François Bertel (developer)
2009-12-28 06:18

The use of == in the lines you listed is perfectly valid.

There are not comparing an expected value to a result of a computation (which should be done with something like fabs(a-b)<someEpsilon) but
compare values to previous assigned values to prevent call to Modified().

The summary for this bug report does not make sense. How it is relevant to the note you added? What is the dead loop you are talking about?
(0018998)
hfxt (reporter)
2009-12-28 07:33

Graphics\vtkStreamer.cxx
when i compute streamline,it has a vortex(unlimited curve)
L383 d==0
it should be "d<=someEpsilon",break loop as soon as possible.
(0019015)
François Bertel (developer)
2009-12-30 05:58

Fixed in revision 1.65 of vtkStreamer.h and revision 1.93 of vtkStreamer.cxx on 2009-12-30 in CVS HEAD (VTK 5.5).

 Issue History
Date Modified Username Field Change
2009-12-16 22:20 hfxt New Issue
2009-12-28 06:12 François Bertel Status backlog => tabled
2009-12-28 06:12 François Bertel Assigned To => François Bertel
2009-12-28 06:18 François Bertel Note Added: 0018997
2009-12-28 07:33 hfxt Note Added: 0018998
2009-12-30 05:58 François Bertel Note Added: 0019015
2009-12-30 05:58 François Bertel Status tabled => @80@
2009-12-30 05:58 François Bertel Resolution open => fixed
2011-06-16 13:11 Zack Galbreath Category => (No Category)
2013-04-05 19:57 Berk Geveci Status customer review => closed


Copyright © 2000 - 2018 MantisBT Team