View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014200VTK(No Category)public2013-07-31 01:562014-10-02 13:39
ReporterSteffen Salbert 
Assigned ToCory Quammen 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version6.0.0 
Target VersionFixed in Version 
Summary0014200: Incorrect text scaling in vtkAxisActor2D.cxx
DescriptionThere seems to be an error in the vtkAxisActor2D class when enabling automatic sizing of the text relative to the axes. In some cases the text gets bigger when zooming out, instead of getting smaller.

The source code of the problem is the following:

if ( this->SizeFontRelativeToAxis )
{
    xp1 = this->PositionCoordinate->GetComputedDoubleDisplayValue(viewport);
    xp2 = this->Position2Coordinate->GetComputedDoubleViewportValue(viewport);
    len = sqrt((xp2[0]-xp1[0])*(xp2[0]-xp1[0]) + (xp2[1]-xp1[1])*(xp2[1]-xp1[1]));
}

The distance between the lower left and the upper right coordinate is computed, but the coordinates are in different coordinate systems. Changing the computation of xp1 to "this->PositionCoordinate->GetComputedDoubleViewportValue(viewport);" will fix the problem. (see picture)

TagsNo tags attached.
ProjectKitware
Typeincorrect functionality
Attached Filespng file icon VTKBug.png [^] (802,358 bytes) 2013-07-31 01:56

 Relationships

  Notes
(0031957)
Dave DeMarle (administrator)
2013-12-16 16:00

 http://review.source.kitware.com/#/t/3731 [^]
(0031981)
Dave DeMarle (administrator)
2013-12-17 13:09

 proposed patch showed problems in gerrit/dashboard tests
(0033497)
Cory Quammen (developer)
2014-10-02 13:39

 Fix merged in

commit 2d3ecda0dfc6a487789103db361520250983dacb
Author: Dave DeMarle <dave.demarle@kitware.com>
Date: Mon Dec 16 15:58:32 2013 -0500

    bug#0014200 fix incorrect text scaling
    
    per bug 142000.
    Thanks Steffen Salbert for the patch
    
    Change-Id: I592f14616a217b2d5a3403573b14c491e49b143f

Presumably the dashboard errors Dave reported are fixed, as VTK master does not show any errors for vtkAxisActor2D.

 Issue History
Date Modified Username Field Change
2013-07-31 01:56 Steffen Salbert New Issue
2013-07-31 01:56 Steffen Salbert File Added: VTKBug.png
2013-12-16 16:00 Dave DeMarle Note Added: 0031957
2013-12-16 16:00 Dave DeMarle Assigned To => Dave DeMarle
2013-12-16 16:00 Dave DeMarle Status backlog => gerrit review
2013-12-17 13:09 Dave DeMarle Note Added: 0031981
2013-12-17 13:09 Dave DeMarle Status gerrit review => backlog
2014-09-30 10:55 Dave DeMarle Assigned To Dave DeMarle =>
2014-10-02 13:39 Cory Quammen Note Added: 0033497
2014-10-02 13:39 Cory Quammen Status backlog => closed
2014-10-02 13:39 Cory Quammen Assigned To => Cory Quammen
2014-10-02 13:39 Cory Quammen Resolution open => fixed

Copyright © 2000 - 2018 MantisBT Team