View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015065VTK(No Category)public2014-10-22 17:012015-02-11 14:18
ReporterOrion Poplawski 
Assigned ToBen Boeckel (Kitware) 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version6.0.0 
Target VersionFixed in Version6.2.0 
Summary0015065: Do not use get_filename_component to determine VTK_INSTALL_PREFIX
DescriptionOn systems with /lib64 -> /usr/lib64 (Fedora UsrMove), VTKConfig.cmake incorrectly set VTK_INSTALL_PREFIX to "/", resulting in "//include/vtk" in VTK_INCLUDE_DIRS. VTK_INSTALL_PREFIX is known at compile/install time and should be set accordingly.
TagsNo tags attached.
ProjectTBD
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0034148)
Orion Poplawski (reporter)
2015-02-03 18:00

This appears to be fixed in VTK git and can probably be closed.
(0034150)
Orion Poplawski (reporter)
2015-02-03 18:33

Sorry, my mistake, this is still an issue:

CMake/vtkModuleTop.cmake:
# Generate VTKConfig.cmake for the install tree.
set(VTK_CONFIG_CODE "
# Compute the installation prefix from this VTKConfig.cmake file location.
get_filename_component(VTK_INSTALL_PREFIX \"\${CMAKE_CURRENT_LIST_FILE}\" PATH)")
# Construct the proper number of get_filename_component(... PATH)
# calls to compute the installation prefix.
string(REGEX REPLACE "/" ";" _count "${VTK_INSTALL_PACKAGE_DIR}")
foreach(p ${_count})
  set(VTK_CONFIG_CODE "${VTK_CONFIG_CODE}
get_filename_component(VTK_INSTALL_PREFIX \"\${VTK_INSTALL_PREFIX}\" PATH)")
endforeach()
(0034163)
Dave DeMarle (administrator)
2015-02-05 12:13

@Ben, please take a look and see if this is as trivial to fix as it looks and decide on 6.2 or 6.3 target.
(0034198)
Ben Boeckel (Kitware) (developer)
2015-02-09 15:54

http://review.source.kitware.com/#/t/5446 [^]
(0034207)
Brad King (developer)
2015-02-11 10:41

VTK should use the approach that CMake does for install(EXPORT) here:

 http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmExportInstallFileGenerator.cxx;hb=v3.1.2#l72 [^]

Basically it saves knowledge of the original install prefix, and if the current location is just a symlink to that, it uses the original instead of the symlinked path.
(0034210)
Ben Boeckel (Kitware) (developer)
2015-02-11 14:18

Merged.

 Issue History
Date Modified Username Field Change
2014-10-22 17:01 Orion Poplawski New Issue
2015-02-03 18:00 Orion Poplawski Note Added: 0034148
2015-02-03 18:33 Orion Poplawski Note Added: 0034150
2015-02-05 12:12 Dave DeMarle Assigned To => Ben Boeckel (Kitware)
2015-02-05 12:13 Dave DeMarle Note Added: 0034163
2015-02-09 15:54 Ben Boeckel (Kitware) Note Added: 0034198
2015-02-09 15:54 Ben Boeckel (Kitware) Status backlog => gerrit review
2015-02-11 10:41 Brad King Note Added: 0034207
2015-02-11 14:18 Ben Boeckel (Kitware) Note Added: 0034210
2015-02-11 14:18 Ben Boeckel (Kitware) Status gerrit review => closed
2015-02-11 14:18 Ben Boeckel (Kitware) Resolution open => fixed
2015-02-11 14:18 Ben Boeckel (Kitware) Fixed in Version => 6.2.0


Copyright © 2000 - 2018 MantisBT Team