View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001559

VTK

(No Category)

public

2005-02-01 08:58

2016-08-12 09:54

Reporter

Hideaki Hiraki

Assigned To

Will Schroeder

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001559: MaximumDistance is left in vtkImageEuclideanDistance when ConsiderAnisotropy is On

Description

The following script should show a concentric distance map, but a very high value is shown spuriously on it.

vtkSphere sphere
vtkSampleFunction sample
sample SetImplicitFunction sphere
vtkImageThreshold thresh
thresh SetInput [sample GetOutput]
thresh ThresholdByUpper 0
thresh SetInValue 1
thresh SetOutValue 0
vtkImageEuclideanDistance distan
distan SetInput [thresh GetOutput]
vtkImageViewer viewer
viewer SetInput [distan GetOutput]
viewer SetColorWindow 2
viewer SetColorLevel 1
viewer Render

In vtkImageEuclideanDistance, the default MaximumDistance is VTK_INT_MAX. The spurious parts keep the value unprocessed. Though I couldn't understand the algorithm, I found suspect lines in vtkImageEuclideanDistance.cxx :
b=(int)(floor)((((buff[idx0]-buffer)/spacing)-1)/2);

The variables buff[idx0] and buffer seem to be set squared distances. It's strange to divide only once by spacing. Moreover, if one of these variables was VTK_INT_MAX and spacing<<1, the result would overflow.

Tags

No tags attached.

Project

Type

Attached Files

distfix.patch [^] (1,809 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

--- Imaging/vtkImageEuclideanDistance.cxx~	2003-12-23 23:06:33.000000000 +0900
+++ Imaging/vtkImageEuclideanDistance.cxx	2005-06-06 15:49:47.000000000 +0900
@@ -304,8 +304,9 @@
           if(a>0) {a--;}
           if(buff[idx0]>buffer+sq[1]) 
             {
-            b=(int)(floor)((((buff[idx0]-buffer)/spacing)-1)/2); 
-            if((idx0+b)>outMax0) {b=(outMax0)-idx0;}
+            b=(outMax0)-idx0;
+            m=(((buff[idx0]-buffer)/spacing)-1)/2;
+            if(b>m) {b=(int)(floor)(m);}
                       
             for(n=a;n<=b;n++) 
               {
@@ -333,8 +334,9 @@
           if(a>0) {a--;}
           if(buff[idx0]>buffer+sq[1]) 
             {
-            b=(int)(floor)((((buff[idx0]-buffer)/spacing)-1)/2); 
-            if((idx0-b)<outMin0) {b=idx0-outMin0;}
+            b=idx0-outMin0;
+            m=(((buff[idx0]-buffer)/spacing)-1)/2;
+            if(b>m) {b=(int)(floor)(m);}
                     
             for(n=a;n<=b;n++) 
               {
@@ -491,8 +493,9 @@
           
           if(buff[idx0]>buffer+sq[1]) 
             {
-            b=(int)(floor)((((buff[idx0]-buffer)/spacing)-1)/2); 
-            if((idx0+b)>outMax0) {b=(outMax0)-idx0;}
+            b=(outMax0)-idx0;
+            m=(((buff[idx0]-buffer)/spacing)-1)/2;
+            if(b>m) {b=(int)(floor)(m);}
                       
             for(n=a;n<=b;n++) 
               {
@@ -521,8 +524,9 @@
           if(a>0) {a--;}
           if(buff[idx0]>buffer+sq[1]) 
             {
-            b=(int)(floor)((((buff[idx0]-buffer)/spacing)-1)/2); 
-            if((idx0-b)<outMin0) b=idx0-outMin0;
+            b=idx0-outMin0;
+            m=(((buff[idx0]-buffer)/spacing)-1)/2;
+            if(b>m) {b=(int)(floor)(m);}
                     
             for(n=a;n<=b;n++) 
               {

Relationships

Notes
(0002465) Hideaki Hiraki (reporter) 2005-06-06 03:04	I found spacing here was squared in several lines above: spacing*=spacing; So it's not strange to divide once by this. Anyway, I could fix the spurious parts by checking the range before casting to integer. Please see the attachment.

(0036764) Kitware Robot (administrator) 2016-08-12 09:54	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)
2016-08-12 09:54	Kitware Robot	Note Added: 0036764
2016-08-12 09:54	Kitware Robot	Status	expired => closed
2016-08-12 09:54	Kitware Robot	Resolution	open => moved