View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002929VTK(No Category)public2006-03-02 05:202016-08-12 09:54
ReporterJens Henrik Goebbert 
Assigned ToDave DeMarle 
PrioritylowSeverityfeatureReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0002929: faster vtkCellLocator with buckets = sqrt(NumberOfCells)
DescriptionI think that vtkCellLocator is faster if it sets the number of buckets to sqrt(NumberOfCells) instead of fixed 25.
(the same is true for vtkPointLocator, too)
TagsNo tags attached.
Project
Type
Attached Files

 Relationships

  Notes
(0003824)
Mathieu Malaterre (developer)
2006-03-02 13:09

Do you have a way to test/reproduce ?
(0003828)
Jens Henrik Goebbert (reporter)
2006-03-02 18:48

Suppose...
(1)... it would take one step to check if a bucket contains the searched cell.
(2)... it would take one step to check if a cell is the one we are searching for.

In average we would have to check half the buckets to find the correct one and
half the cells in that bucket to find the searched cell.
We would need
    steps = buckets/2 + cells_per_bucket/2
with
    number_of_cells = buckets*cells_per_bucket

=> if "buckets" and "cells_per_bucket" would be the same size, "steps" would be minimum.

Of course (1) and (2) do not take the same amount of calculation-time. So my thoughts may not
be exact. But simply having 25 buckets seems to me worse.
(0030952)
Jean-Christophe Fillion-Robin (manager)
2013-06-05 17:46

Could you check if the performance issue have been fixed in either VTK 5.10 or VTK 6 ? Ideally, providing a small program allowing to benchmark the proposed change would be helpful.

In addition, if you would like, you could submit a patch using Gerrit. This would make the review and integration easier. For more details see http://www.vtk.org/Wiki/VTK/Git/Develop [^]
(0031220)
Dave DeMarle (administrator)
2013-07-22 19:18

If the bug persists in 6.0.0, please reopen.
(0036838)
Kitware Robot (administrator)
2016-08-12 09:54

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2008-11-30 09:13 Mathieu Malaterre Assigned To Mathieu Malaterre => David Cole
2011-01-19 09:57 David Cole Assigned To David Cole =>
2011-06-16 13:11 Zack Galbreath Category => (No Category)
2013-06-05 17:46 Jean-Christophe Fillion-Robin Note Added: 0030952
2013-07-22 19:18 Dave DeMarle Note Added: 0031220
2013-07-22 19:18 Dave DeMarle Status backlog => expired
2013-07-22 19:18 Dave DeMarle Assigned To => Dave DeMarle
2016-08-12 09:54 Kitware Robot Note Added: 0036838
2016-08-12 09:54 Kitware Robot Status expired => closed
2016-08-12 09:54 Kitware Robot Resolution open => moved


Copyright © 2000 - 2018 MantisBT Team