View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003323

VTK

(No Category)

public

2006-06-05 09:19

2011-01-13 17:00

Reporter

Charles De Lean

Assigned To

Mathieu Malaterre

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0003323: MPEG writer is leaking memory

Description

When writing out a movie, the MPEG writer is not releasing memory of the different images until the whole movie is generated.

Looks like a minor logic error: although the MPEG writer has code meant to release images from the has h table, this code is not using the erase method properly.

Suggest using the method with single parameter as proposed in following patch.

Fixed problem on local copy.

===================================================================
RCS file: /cvsroot/VTK/VTK/IO/vtkMPEG2Writer.cxx,v
retrieving revision 1.3
diff -u -3 -r1.3 vtkMPEG2Writer.cxx
--- IO/vtkMPEG2Writer.cxx 23 Aug 2005 13:42:26 -0000 1.3
+++ IO/vtkMPEG2Writer.cxx 25 May 2006 01:57:44 -0000
@@ -155,7 +155,7 @@
     {
     return 0;
     }
- this->ImagesMap.erase(it, it);
+ this->ImagesMap.erase(it);
   return 0;
}
//---------------------------------------------------------------------------

Tags

No tags attached.

Project

Type

Attached Files

Relationships

Notes
(0004544) Mathieu Malaterre (developer) 2006-07-25 19:53	Thanks for bug report and patch ! $ cvs ci -m"BUG: Fix Bug 0003323 - MPEG writer is leaking memory. The patch was applied on VTK CVS but not propagated on VTK5 branch" /cvsroot/ParaView/ParaView/VTK/IO/vtkMPEG2Writer.cxx,v <-- vtkMPEG2Writer.cxx new revision: 1.3.4.1; previous revision: 1.3

Issue History
Date Modified	Username	Field	Change
2011-01-13 17:00		Source_changeset_attached	=> VTK master a2bd8391
2011-01-13 17:00		Source_changeset_attached	=> VTK master 020ef709
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)