View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003566

VTK

(No Category)

public

2006-08-01 12:20

2011-01-13 17:00

Reporter

Sean McBride

Assigned To

Mathieu Malaterre

Priority

low

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0003566: Performance improvement for vtk using Carbon

Description

The docs for the aglSwapBuffers() function say:

<http://www.devworld.apple.com/documentation/GraphicsImaging/Reference/AGL_OpenGL/Reference/reference.html#//apple_ref/c/func/aglSwapBuffers> [^]
"The aglSwapBuffers function either swaps the buffers or copies the back buffer content to the front buffer. Before it returns, aglSwapBuffers invokes the OpenGL function glFlush"

Similiarly, this doc say:

<http://developer.apple.com/technotes/tn2004/tn2093.html> [^]
"For instance, you could use glFlush() to force drawing updates at the end of a draw loop, but you would not want to do this right before a call to a buffer swapping command (such as aglSwapBuffers(), which contains an implicit glFlush() itself)."

vtk is making this mistake.

I have attached a patch. I have tested that my dashboard succeeds, but have not done further testing. I believe the change is quite safe.

Tags

No tags attached.

Project

Type

Attached Files

patch.txt [^] (741 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

Index: Rendering/vtkCarbonRenderWindow.cxx
===================================================================
RCS file: /cvsroot/VTK/VTK/Rendering/vtkCarbonRenderWindow.cxx,v
retrieving revision 1.44
diff -u -3 -r1.44 vtkCarbonRenderWindow.cxx
--- Rendering/vtkCarbonRenderWindow.cxx	31 Mar 2006 21:05:36 -0000	1.44
+++ Rendering/vtkCarbonRenderWindow.cxx	1 Aug 2006 16:10:48 -0000
@@ -685,12 +685,15 @@
 void vtkCarbonRenderWindow::Frame()
 {
   this->MakeCurrent();
-  glFlush();
   if (!this->AbortRender && this->DoubleBuffer && this->SwapBuffers)
     {
     aglSwapBuffers(this->ContextId);
     vtkDebugMacro(<< " aglSwapBuffers\n");
     }
+  else
+    {
+	glFlush();
+    }
 }
   
 AGLContext vtkCarbonRenderWindow::GetContextId()

glflush.patch [^] (1,810 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

? Rendering/.vtkCocoaRenderWindow.h.swp
? Rendering/.vtkCocoaRenderWindow.mm.swp
? Rendering/.vtkCocoaRenderWindowInteractor.mm.swp
Index: Rendering/vtkCarbonRenderWindow.cxx
===================================================================
RCS file: /cvsroot/ParaView/ParaView/VTK/Rendering/vtkCarbonRenderWindow.cxx,v
retrieving revision 1.44
diff -u -3 -p -r1.44 vtkCarbonRenderWindow.cxx
--- Rendering/vtkCarbonRenderWindow.cxx	31 Mar 2006 21:05:36 -0000	1.44
+++ Rendering/vtkCarbonRenderWindow.cxx	4 Sep 2006 01:04:11 -0000
@@ -685,12 +685,15 @@ void vtkCarbonRenderWindow::SetPosition(
 void vtkCarbonRenderWindow::Frame()
 {
   this->MakeCurrent();
-  glFlush();
   if (!this->AbortRender && this->DoubleBuffer && this->SwapBuffers)
     {
     aglSwapBuffers(this->ContextId);
     vtkDebugMacro(<< " aglSwapBuffers\n");
     }
+  else
+    {
+    glFlush();
+    }
 }
   
 AGLContext vtkCarbonRenderWindow::GetContextId()
Index: Rendering/vtkXOpenGLRenderWindow.cxx
===================================================================
RCS file: /cvsroot/ParaView/ParaView/VTK/Rendering/vtkXOpenGLRenderWindow.cxx,v
retrieving revision 1.73
diff -u -3 -p -r1.73 vtkXOpenGLRenderWindow.cxx
--- Rendering/vtkXOpenGLRenderWindow.cxx	8 Jul 2006 16:34:16 -0000	1.73
+++ Rendering/vtkXOpenGLRenderWindow.cxx	4 Sep 2006 01:04:11 -0000
@@ -401,15 +401,18 @@ vtkXOpenGLRenderWindow::~vtkXOpenGLRende
 }
 
 // End the rendering process and display the image.
-void vtkXOpenGLRenderWindow::Frame(void)
+void vtkXOpenGLRenderWindow::Frame()
 {
   this->MakeCurrent();
-  glFlush();
   if (!this->AbortRender && this->DoubleBuffer && this->SwapBuffers)
     {
     glXSwapBuffers(this->DisplayId, this->WindowId);
     vtkDebugMacro(<< " glXSwapBuffers\n");
     }
+  else
+    {
+    glFlush();
+    }
 }
  
 //

Relationships

Notes
(0004838) Mathieu Malaterre (developer) 2006-09-04 10:21	$ cvs ci -m"BUG: Fix Bug 0003566 - Performance improvement for vtk using Carbon" Rendering/vtkCarbonRenderWindow.cxx /cvsroot/VTK/VTK/Rendering/vtkCarbonRenderWindow.cxx,v <-- vtkCarbonRenderWindow.cxx new revision: 1.45; previous revision: 1.44

Issue History
Date Modified	Username	Field	Change
2011-01-13 17:00		Source_changeset_attached	=> VTK master a2bd8391
2011-01-13 17:00		Source_changeset_attached	=> VTK master 020ef709
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)