View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000362

VTK

(No Category)

public

2003-11-11 12:12

2011-01-13 17:00

Reporter

Vladan Bato

Assigned To

Mathieu Malaterre

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000362: vtkAxisActor2D is not updated when window size changes

Description

If the window size changes, but the axis position
remains the same, the labels are not updated as
they should.

This is because in vtkAxisActor2D::BuildAxis(), if the viewport has changed, the function only checks whether the position of the actor has changed.
If it is the same, the function exits, and the labels are not updated (the size of the labels should change when window size changes).

This only happens when changing the window size
does not change the position of the axis.

The function should be modified to check the size
of the window too.

Tags

No tags attached.

Project

Type

Attached Files

vtkAxisActor2D.patch [^] (1,609 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

Index: vtkAxisActor2D.cxx
===================================================================
RCS file: /cvsroot/VTK/VTK/Rendering/vtkAxisActor2D.cxx,v
retrieving revision 1.34
diff -u -b -r1.34 vtkAxisActor2D.cxx
--- vtkAxisActor2D.cxx	17 Dec 2002 02:03:07 -0000	1.34
+++ vtkAxisActor2D.cxx	12 Nov 2003 12:10:23 -0000
@@ -315,7 +315,22 @@
       }
     }
   
-  if (!positionsHaveChanged &&
+  size = viewport->GetSize();
+
+  // See whether fonts have to be rebuilt (font size depends on viewport size)
+
+  if (this->LastSize[0] != size[0] || this->LastSize[1] != size[1])
+    {
+    viewportSizeHasChanged = 1;
+    this->LastSize[0] = size[0];
+    this->LastSize[1] = size[1];
+    }
+  else
+    {
+    viewportSizeHasChanged = 0;
+    }
+
+  if (!positionsHaveChanged && !viewportSizeHasChanged &&
       this->GetMTime() < this->BuildTime &&
       (!this->LabelVisibility || 
        this->LabelTextProperty->GetMTime() < this->BuildTime) &&
@@ -363,8 +378,6 @@
   this->LastPosition2[0] = x[0]; 
   this->LastPosition2[1] = x[1];
 
-  size = viewport->GetSize();
-
   vtkPoints *pts = vtkPoints::New();
   vtkCellArray *lines = vtkCellArray::New();
   this->Axis->SetPoints(pts);
@@ -428,19 +441,6 @@
       }
     }
 
-  // See whether fonts have to be rebuilt (font size depends on viewport size)
-
-  if (this->LastSize[0] != size[0] || this->LastSize[1] != size[1])
-    {
-    viewportSizeHasChanged = 1;
-    this->LastSize[0] = size[0];
-    this->LastSize[1] = size[1];
-    }
-  else
-    {
-    viewportSizeHasChanged = 0;
-    }
-
   // Build the labels
 
   if (this->LabelVisibility)

Relationships

Notes
(0000256) Vladan Bato (reporter) 2003-11-12 07:16	I think I have fixed it. I uploaded a patch as an attachment. It's a diff against rev. 1.34 of the file. All I did is move the code that sets vieportSizeHasChanged before the if() that exits the function, and added a check of viewportSizeHasChanged in the same if.

(0000665) Mathieu Malaterre (developer) 2004-02-17 18:48	Fixed has been merge in CVS, thank you Vladan Bato.

Issue History
Date Modified	Username	Field	Change
2010-11-29 17:59	Mathieu Malaterre	Source_changeset_attached	=> VTK master 5a5b9cbf
2011-01-13 17:00		Source_changeset_attached	=> VTK master a2bd8391
2011-01-13 17:00		Source_changeset_attached	=> VTK master 020ef709
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)