View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0006277 | VTK | (No Category) | public | 2008-01-25 15:03 | 2010-11-04 08:53 | ||||
Reporter | Sean McBride | ||||||||
Assigned To | David Cole | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | Mac OS X | OS | Mac OS X | OS Version | 10.5 | ||||
Product Version | |||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0006277: VTK should not force -no-cpp-precomp compiler flag on Mac OS X | ||||||||
Description | In VTK's main vtkDetermineCompilerFlags.cmake there is the following: IF(APPLE) <snip> IF(CMAKE_COMPILER_IS_GNUCXX) SET(VTK_REQUIRED_C_FLAGS "${VTK_REQUIRED_C_FLAGS} -no-cpp-precomp") SET(VTK_REQUIRED_CXX_FLAGS "${VTK_REQUIRED_CXX_FLAGS} -no-cpp-precomp") <snip> I would like to request that the "-no-cpp-precomp" be removed. Basically, it is an obsolete flag that is only in Apple's gcc and not the FSF gcc. It's not even in the man page. The reason I make this request is that in beta versions of Apple's gcc 4.2 the flag is gone, and so VTK cannot be built the way it is now. If I remove the flag, VTK builds fine. This link has more info: http://gcc.gnu.org/ml/gcc-prs/2003-05/msg01546.html [^] The only reason I see to keep it is if it is absolutely needed for some really old Apple gcc, like 2.95. And even then it would need to be conditionalised. Since VTK 5.4 will probably be out long after gcc 4.2 (given VTK's release frequency), I'd really like to see this fixed for VTK 5.2, so VTK will work with gcc 4.2 when it arrives in a future Xcode update. | ||||||||
Tags | No tags attached. | ||||||||
Project | |||||||||
Type | |||||||||
Attached Files | 6277patch.txt [^] (1,012 bytes) 2008-06-16 17:21 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0012352) Sean McBride (developer) 2008-06-16 17:23 |
David, could you review this patch? It's working for me on 10.5.3 and Xcode 3.1b7 with gcc 4.2. If its ok, can you commit it to both 5.2 and 5.3? Thanks. |
(0012698) Sean McBride (developer) 2008-07-14 17:17 |
Xcode 3.1 was publicly released a couple of days ago and includes gcc 4.2, others may now start to run into this... |
(0012707) David Cole (developer) 2008-07-15 11:40 |
Sean, Go ahead and apply the patch. If all goes well on CVS HEAD with the nightly dashboards, I will merge it into VTK-5-2 also. Thanks, David |
(0012773) Sean McBride (developer) 2008-07-21 12:06 |
I didn't use the previously attached patch, instead I copied ITK's solution to the related bug: /cvsroot/VTK/VTK/CMake/vtkCheckCXXAcceptsFlags.cmake,v <-- vtkCheckCXXAcceptsFlags.cmake initial revision: 1.1 /cvsroot/VTK/VTK/CMake/vtkDetermineCompilerFlags.cmake,v <-- vtkDetermineCompilerFlags.cmake new revision: 1.10; previous revision: 1.9 David, can you apply to 5.2 branch? |
(0012984) David Cole (developer) 2008-08-11 16:24 |
Applied to VTK-5-2 : /cvsroot/VTK/VTK/CMake/vtkCheckCXXAcceptsFlags.cmake,v <-- CMake/vtkCheckCXXAcceptsFlags.cmake new revision: 1.1.2.2; previous revision: 1.1.2.1 /cvsroot/VTK/VTK/CMake/vtkDetermineCompilerFlags.cmake,v <-- CMake/vtkDetermineCompilerFlags.cmake new revision: 1.6.2.3; previous revision: 1.6.2.2 |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2008-01-25 15:03 | Sean McBride | New Issue | |
2008-01-28 16:07 | Sean McBride | Description Updated | |
2008-02-07 13:37 | Sean McBride | Description Updated | |
2008-06-16 17:21 | Sean McBride | File Added: 6277patch.txt | |
2008-06-16 17:22 | Sean McBride | Status | backlog => tabled |
2008-06-16 17:22 | Sean McBride | Assigned To | => David Cole |
2008-06-16 17:23 | Sean McBride | Note Added: 0012352 | |
2008-07-14 17:17 | Sean McBride | Note Added: 0012698 | |
2008-07-15 11:39 | David Cole | Assigned To | David Cole => Sean McBride |
2008-07-15 11:40 | David Cole | Note Added: 0012707 | |
2008-07-21 12:06 | Sean McBride | Status | tabled => @80@ |
2008-07-21 12:06 | Sean McBride | Resolution | open => fixed |
2008-07-21 12:06 | Sean McBride | Note Added: 0012773 | |
2008-07-21 12:07 | Sean McBride | Assigned To | Sean McBride => David Cole |
2008-07-21 12:07 | Sean McBride | Status | @80@ => tabled |
2008-08-11 16:24 | David Cole | Note Added: 0012984 | |
2008-08-11 16:25 | David Cole | Status | tabled => @80@ |
2010-11-04 08:53 | Brad King | Status | @80@ => closed |
2011-06-16 13:11 | Zack Galbreath | Category | => (No Category) |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |