View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007818VTK(No Category)public2008-10-15 21:012012-06-19 22:06
ReporterClinton Stimpson 
Assigned ToSean McBride 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0007818: better mapping of cocoa concepts to vtk concepts
Description
Assuming VTK uses the same concept as X11 and Win32 in their api (which is very likely), I suggest mapping these concepts for Cocoa...

NSView -- VTK WindowId
n/a -- VTK DisplayId
NSWindow -- new VTK concept, or keep it in Cocoa/Carbon implementations. Its possible for the code to get an NSWindow from an NSView, so one shouldn't be required to provide that info to vtkCocoaRenderWindow.

TagsNo tags attached.
Project
Type
Attached Filestxt file icon VTK-bug-7818-patch.txt [^] (18,086 bytes) 2009-02-10 18:55 [Show Content]
patch file icon qt-cocoa.patch [^] (1,198 bytes) 2009-02-11 13:10 [Show Content]

 Relationships

  Notes
(0013893)
Sean McBride (developer)
2008-10-16 10:03

See also vtkdev thread titled "vtkCocoaRenderWindow qq" on 2008-10-01.
(0014888)
Sean McBride (developer)
2009-02-10 18:56

Clinton, attached is a patch. Care to give it a try?

It changes:

WindowId -> RootWindow
DispayId -> WindowId
(0014897)
Clinton Stimpson (developer)
2009-02-11 12:39

tested with paraview and it worked fine. Let me know when you commit it, so I can update the Qt code at the same time.

Also, don't forget to update Common/vtkJavaAwt.h and replace SetDisplayId with SetWindowId.
(0014898)
Sean McBride (developer)
2009-02-11 12:57

Clinton, yes I missed vtkJavaAwt.h, thanks!

Could you add a patch with the necessary Qt code to this bug? Then I can create a mega patch. :) Also, it lets us both test the same changes locally for a while.
(0014899)
Clinton Stimpson (developer)
2009-02-11 13:10

I've uploaded a patch for changes on the Qt side.
(0017134)
Sean McBride (developer)
2009-08-14 13:03

/cvsroot/VTK/VTK/Common/vtkJavaAwt.h,v <-- Common/vtkJavaAwt.h
new revision: 1.27; previous revision: 1.26
/cvsroot/VTK/VTK/Examples/GUI/Cocoa/BasicVTKView.mm,v <-- Examples/GUI/Cocoa/BasicVTKView.mm
new revision: 1.6; previous revision: 1.5
/cvsroot/VTK/VTK/Rendering/vtkCocoaRenderWindow.h,v <-- Rendering/vtkCocoaRenderWindow.h
new revision: 1.40; previous revision: 1.39
/cvsroot/VTK/VTK/Rendering/vtkCocoaRenderWindow.mm,v <-- Rendering/vtkCocoaRenderWindow.mm
new revision: 1.67; previous revision: 1.66
/cvsroot/VTK/VTK/Rendering/vtkCocoaRenderWindowInteractor.mm,v <-- Rendering/vtkCocoaRenderWindowInteractor.mm
new revision: 1.28; previous revision: 1.27
(0017135)
Clinton Stimpson (developer)
2009-08-14 13:08

Removed all Cocoa specific code in #ifdefs.
/cvsroot/VTK/VTK/GUISupport/Qt/QVTKWidget.cxx,v <-- QVTKWidget.cxx
new revision: 1.44; previous revision: 1.43
(0028704)
Clinton Stimpson (developer)
2012-06-19 22:06

Already fixed a while back.

 Issue History
Date Modified Username Field Change
2008-10-15 21:01 Clinton Stimpson New Issue
2008-10-15 21:01 Clinton Stimpson Status backlog => tabled
2008-10-15 21:01 Clinton Stimpson Assigned To => Sean McBride
2008-10-16 10:03 Sean McBride Note Added: 0013893
2009-02-10 18:55 Sean McBride File Added: VTK-bug-7818-patch.txt
2009-02-10 18:56 Sean McBride Note Added: 0014888
2009-02-11 12:39 Clinton Stimpson Note Added: 0014897
2009-02-11 12:57 Sean McBride Note Added: 0014898
2009-02-11 13:10 Clinton Stimpson File Added: qt-cocoa.patch
2009-02-11 13:10 Clinton Stimpson Note Added: 0014899
2009-08-14 13:03 Sean McBride Note Added: 0017134
2009-08-14 13:08 Clinton Stimpson Note Added: 0017135
2011-01-13 17:00 Source_changeset_attached => VTK master a2bd8391
2011-01-13 17:00 Source_changeset_attached => VTK master 020ef709
2011-06-16 13:11 Zack Galbreath Category => (No Category)
2012-06-19 22:06 Clinton Stimpson Note Added: 0028704
2012-06-19 22:06 Clinton Stimpson Status backlog => closed
2012-06-19 22:06 Clinton Stimpson Resolution open => fixed


Copyright © 2000 - 2018 MantisBT Team