View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007822

VTK

(No Category)

public

2008-10-16 17:10

2008-10-21 17:08

Reporter

Adam Williamson

Assigned To

Sebastien Barre

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0007822: Use of deprecated interp->result makes VTK un-buildable on Tcl/Tk 8.6

Description

The use of interp->result has been deprecated in Tcl for many years, and with 8.6 they're finally making it not work by default. Using this method will result in an error when building against Tcl/Tk 8.6 unless you do #define USE_INTERP_RESULT before including tcl.h - that, however, is a hack intended to aid migration, the expectation is that the code should be fixed. For Tcl/Tk 9.0 it will be made completely impossible to use interp->result.

Additional Information

VTK uses it in three files: VTK/Common/vtkTclUtil.cxx , VTK/Rendering/vtkTkRenderWidget.cxx and VTK/Rendering/vtkTkImageViewerWidget.cxx . Unfortunately I'm not a hacker so I can't provide an exact patch and be confident it's correct, but I can give some pointers. This is TIP 0000330: http://www.tcl.tk/cgi-bin/tct/tip/330.html [^] . The correct method is to use Tcl_GetStringResult if you're trying to read the result, and Tcl_SetStringResult if you're trying to set it.

The files in Render use it like this:

self->Interp->result

in multiple places, all very similar. vtkTclUtil.cxx uses it like this:

sprintf(temps,"vtk bad argument, type conversion failed for object %s.\nCould not type convert %s which is of type %s, to type %s.\n", name, name, i->result, result_type);

hope that's enough information to fix it. Thanks!

Tags

No tags attached.

Project

Type

Attached Files

Relationships

Notes
(0013896) Adam Williamson (reporter) 2008-10-16 17:11	Correction: Tcl_SetResult , not Tcl_SetStringResult .

(0013918) Sebastien Barre (developer) 2008-10-21 17:08	Fixed, thanks for the report. Email to follow on the VTK user list

Issue History
Date Modified	Username	Field	Change
2008-10-16 17:10	Adam Williamson	New Issue
2008-10-16 17:11	Adam Williamson	Note Added: 0013896
2008-10-21 17:07	Sebastien Barre	Status	backlog => tabled
2008-10-21 17:07	Sebastien Barre	Assigned To	=> Sebastien Barre
2008-10-21 17:08	Sebastien Barre	Note Added: 0013918
2008-10-21 17:08	Sebastien Barre	Status	tabled => closed
2008-10-21 17:08	Sebastien Barre	Resolution	open => fixed
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)