| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0000826 | VTK | (No Category) | public | 2004-05-09 19:57 | 2011-01-13 17:00 | ||||
| Reporter | Goodwin Lawlor | ||||||||
| Assigned To | Mathieu Malaterre | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0000826: Incorrect logic for passing lines through vtkTriangleFilter | ||||||||
| Description | A small cut 'n paste bug... turning on PassLines doesn't pass lines through. PassVerts will pass lines and verts through. Here's the fix: RCS file: /cvsroot/VTK/VTK/Graphics/vtkTriangleFilter.cxx,v retrieving revision 1.51 diff -u -r1.51 vtkTriangleFilter.cxx --- vtkTriangleFilter.cxx 14 Nov 2003 20:43:32 -0000 1.51 +++ vtkTriangleFilter.cxx 9 May 2004 23:48:42 -0000 @@ -93,7 +93,7 @@ if ( !abort && input->GetLines()->GetNumberOfCells() > 0 ) { cells = input->GetLines(); - if ( this->PassVerts ) + if ( this->PassLines ) { newId = output->GetNumberOfCells(); newCells = vtkCellArray::New(); | ||||||||
| Tags | No tags attached. | ||||||||
| Project | |||||||||
| Type | |||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0001028) Mathieu Malaterre (developer) 2004-05-10 12:44 |
Fixed in CVS, thanks for bug report. |
|
(0001032) Goodwin Lawlor (reporter) 2004-05-11 11:45 |
Its unclear from the documentation that PassLines and PassVerts means that PolyVerts and PolyLines are decomposed to Verts and Lines. It could mean that Verts and Lines are simply passed to the output. An explicit explanation would be good. |
|
(0001033) Mathieu Malaterre (developer) 2004-05-11 12:08 |
From vtkTriangleFilter.cxx: ... cells = input->GetVerts(); if ( this->PassVerts ) ... So yes polyverts / polylines remains untouched after filter execution. |
|
(0001034) Goodwin Lawlor (reporter) 2004-05-11 12:57 |
If PassLines==1 then lines are passed to the output and the polylines are passed, decomposed to lines, to the output. If PassLines==0 then no lines or polylines are passed to the output. Same behavior for PassVerts. So polylines/polyverts aren't untouched, they are decomposed. Some explanation in the documentation would be usefull. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2010-11-29 17:59 | Mathieu Malaterre | Source_changeset_attached | => VTK master f8aebb1c |
| 2011-01-13 17:00 | Source_changeset_attached | => VTK master a2bd8391 | |
| 2011-01-13 17:00 | Source_changeset_attached | => VTK master 020ef709 | |
| 2011-06-16 13:11 | Zack Galbreath | Category | => (No Category) |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |