<br><br><div class="gmail_quote">On Wed, Jun 9, 2010 at 12:19 PM, kent williams <span dir="ltr"><<a href="mailto:nkwmailinglists@gmail.com">nkwmailinglists@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
So really the test would have to be something like<br>
<br>
#if ((TCL_MAJOR_VERSION == 8) && (TCL_MINOR_VERSION > 5)) ||<br>
(TCL_MAJOR_VERSION > 8)<br>
<br>
I wonder about this test later on in vtkTclCommand::Execute as well:<br>
<br>
#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION <= 2<br>
res = Tcl_GlobalEval(this->Interp, this->StringCommand);<br>
#else<br>
res = Tcl_EvalEx(this->Interp, this->StringCommand, -1, TCL_EVAL_GLOBAL);<br>
#endif<br>
<br>
Should I log this as a bug and suggest a patch?<br></blockquote><div><br>Sounds like a good plan.....<br><br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div class="h5"><br>
<br>
On Wed, Jun 9, 2010 at 11:12 AM, David Cole <<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>> wrote:<br>
> This is the file in VTK v5.6.0 :<br>
><br>
> <a href="http://www.vtk.org/gitweb?p=VTK.git;a=blob;f=Common/vtkTclUtil.cxx;h=65cc6d9802e520564a0f5bb2d061ace8d2de0929;hb=0c2379496f8eb1767698c9eade4b656c8649ac2f" target="_blank">http://www.vtk.org/gitweb?p=VTK.git;a=blob;f=Common/vtkTclUtil.cxx;h=65cc6d9802e520564a0f5bb2d061ace8d2de0929;hb=0c2379496f8eb1767698c9eade4b656c8649ac2f</a><br>
><br>
> So, no, it does not contain those changes in 5.6.0 either. And even with<br>
> those changes, it won't work when Tcl goes to major version 9... The #ifdef<br>
> goes to the "old way" if TCL_MAJOR_VERSION is non-8...<br>
><br>
><br>
><br>
><br>
> On Wed, Jun 9, 2010 at 12:04 PM, kent williams <<a href="mailto:nkwmailinglists@gmail.com">nkwmailinglists@gmail.com</a>><br>
> wrote:<br>
>><br>
>> According to this bug report, you should be able to build VTK 5.4.2<br>
>> with Tcl/Tk 8.6b1:<br>
>><br>
>> <a href="http://public.kitware.com/Bug/view.php?id=7822" target="_blank">http://public.kitware.com/Bug/view.php?id=7822</a><br>
>><br>
>> But I had to edit one file:<br>
>><br>
>> ===================================================================<br>
>> RCS file: /cvsroot/VTK/VTK/Common/vtkTclUtil.cxx,v<br>
>> retrieving revision 1.95<br>
>> diff -r1.95 vtkTclUtil.cxx<br>
>> 31a32,36<br>
>> > #if (TCL_MAJOR_VERSION == 8) && (TCL_MINOR_VERSION >= 6)<br>
>> > #define TCL_ERROR_LINE(m) (Tcl_GetErrorLine(m))<br>
>> > #else<br>
>> > #define TCL_ERROR_LINE(m) (m->errorLine)<br>
>> > #endif<br>
>> 493c498<br>
>> < " at line number " <<<br>
>> arg2->interp->errorLine);<br>
>> ---<br>
>> > " at line number " <<<br>
>> > TCL_ERROR_LINE(arg2->interp));<br>
>> 499c504<br>
>> < " at line number " <<<br>
>> arg2->interp->errorLine);<br>
>> ---<br>
>> > " at line number " <<<br>
>> > TCL_ERROR_LINE(arg2->interp));<br>
>> 726c731<br>
>> < " at line number " <<<br>
>> this->Interp->errorLine);<br>
>> ---<br>
>> > " at line number " <<<br>
>> > TCL_ERROR_LINE(this->Interp));<br>
>> 733c738<br>
>> < this->Interp->errorLine);<br>
>> ---<br>
>> > TCL_ERROR_LINE(this->Interp));<br>
>><br>
>> Is this fixed in vtk 5.6.0?<br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>><br>
><br>
><br>
</div></div></blockquote></div><br>