Hello Ken,<br><br>Agreed-- will do the interactive rebase.<br><br>Thanks<br>P<br><br><div class="gmail_quote">On Mon, Dec 3, 2012 at 7:57 PM, Moreland, Kenneth <span dir="ltr"><<a href="mailto:kmorel@sandia.gov" target="_blank">kmorel@sandia.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div>
<div>
<div>Philippe,</div>
<div><br>
</div>
<div>Although I agree that gerrit should better handle multiple commits (and we've already had a lengthy email thread on it and I believe there is an action item to improve it), I think a better approach for now is to continue to capture commits in whatever
method fits your development style best and then use something like an interactive rebase to squash the commits when you are ready for review. You could do that for this very gerrit topic.</div>
<div><br>
</div>
<div>-Ken</div>
<div><br>
</div>
</div>
</div>
<span>
<div style="padding:3pt 0in 0in;text-align:left;font-size:11pt;border-width:1pt medium medium;border-style:solid none none;border-color:rgb(181,196,223) -moz-use-text-color -moz-use-text-color;font-family:Calibri">
<span style="font-weight:bold">From: </span>Philippe Pébay <<a href="mailto:philippe.pebay@kitware.com" target="_blank">philippe.pebay@kitware.com</a>><br>
<span style="font-weight:bold">Date: </span>Monday, December 3, 2012 12:13 AM<br>
<span style="font-weight:bold">To: </span>Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
<span style="font-weight:bold">Cc: </span>VTK Developers <<a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a>><br>
<span style="font-weight:bold">Subject: </span>[EXTERNAL] Re: [vtk-developers] Gerrit topis with many changes<br>
</div>
<div><br>
</div>
<blockquote style>
<div>
<div>Hello Bill<br>
<br>
Thanks for your message. It is true that there are a lot of incremental changes but this development is a substantial new feature being added and a lot of the things done in the process are experimental. I need to have many checkpoints.<br>
I think that the development workflow should not overly constrain the developer, otherwise it defeats its very purpose. That said I will remember your advice about the --amend flag and will try to use it as often as possible.<br>
<br>
Thank you<br>
Philippe<br>
<br>
<div class="gmail_quote">On Sun, Dec 2, 2012 at 9:42 PM, Bill Lorensen <span dir="ltr">
<<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Phillipe,<br>
<br>
It is very difficult to review gerrit topic like<br>
<a href="http://review.source.kitware.com/#/t/1805/" target="_blank">http://review.source.kitware.com/#/t/1805/</a> which have so many changes.<br>
I try to keep my topics limited to one or two changes.<br>
For example, one change might correct a bug and another might add or<br>
change a test.<br>
<br>
I see that many of your changes are corrections to other changes.<br>
<br>
If you do a<br>
git add -- filenames<br>
then a<br>
git commit --amend<br>
<br>
the corrections will be part of the last commit.<br>
<br>
If you cut/past the change-id in a commit that you are making a<br>
correction or minor addition to git will keep them part of the<br>
original change.<br>
<br>
To be honest, I don;t do not see how anyone can review a topic like this.<br>
<span><font color="#888888"><br>
Bill<br>
</font></span></blockquote>
</div>
<br>
<br clear="all"><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
<font color="#888888">Philippe Pébay, PhD<br>
</font><font color="#888888">Director of Visualization and High Performance Computing /<br>
</font><font color="#888888">Directeur de la Visualisation et du Calcul Haute Performance<br>
Kitware SAS<br>
26 rue Louis Guérin, 69100 Villeurbanne, France</font><br>
<font color="#888888"><a value="+33426685003">+33 (0) 6.83.61.55.70 / 4.37.45.04.15</a></font><font color="#888888"><br>
<a href="http://www.kitware.fr/" target="_blank">http://www.kitware.fr</a></font><font color="#888888"><a href="http://www.kitware.fr/" target="_blank"></a></font><br>
</font></span></div>
</div>
</blockquote>
</span>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><font color="#888888">Philippe Pébay, PhD<br></font><font color="#888888">Director of Visualization and High Performance Computing /<br>
</font><font color="#888888">Directeur de la Visualisation et du Calcul Haute Performance<br>
Kitware SAS<br>26 rue Louis Guérin, 69100 Villeurbanne, France</font><br>
<font color="#888888"><a value="+33426685003">+33 (0) 6.83.61.55.70 / 4.37.45.04.15</a></font><font color="#888888"><br><a href="http://www.kitware.fr/" target="_blank">http://www.kitware.fr</a></font><font color="#888888"><a href="http://www.kitware.fr/" target="_blank"></a></font><br>