Hello Bill<br><br>Thanks for your message. It is true that there are a lot of incremental changes but this development is a substantial new feature being added and a lot of the things done in the process are experimental. I need to have many checkpoints.<br>
I think that the development workflow should not overly constrain the developer, otherwise it defeats its very purpose. That said I will remember your advice about the --amend flag and will try to use it as often as possible.<br>
<br>Thank you<br>Philippe<br><br><div class="gmail_quote">On Sun, Dec 2, 2012 at 9:42 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Phillipe,<br>
<br>
It is very difficult to review gerrit topic like<br>
<a href="http://review.source.kitware.com/#/t/1805/" target="_blank">http://review.source.kitware.com/#/t/1805/</a> which have so many changes.<br>
I try to keep my topics limited to one or two changes.<br>
For example, one change might correct a bug and another might add or<br>
change a test.<br>
<br>
I see that many of your changes are corrections to other changes.<br>
<br>
If you do a<br>
git add -- filenames<br>
then a<br>
git commit --amend<br>
<br>
the corrections will be part of the last commit.<br>
<br>
If you cut/past the change-id in a commit that you are making a<br>
correction or minor addition to git will keep them part of the<br>
original change.<br>
<br>
To be honest, I don;t do not see how anyone can review a topic like this.<br>
<span class="HOEnZb"><font color="#888888"><br>
Bill<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><font color="#888888">Philippe Pébay, PhD<br></font><font color="#888888">Director of Visualization and High Performance Computing /<br>
</font><font color="#888888">Directeur de la Visualisation et du Calcul Haute Performance<br>
Kitware SAS<br>26 rue Louis Guérin, 69100 Villeurbanne, France</font><br>
<font color="#888888"><a value="+33426685003">+33 (0) 6.83.61.55.70 / 4.37.45.04.15</a></font><font color="#888888"><br><a href="http://www.kitware.fr/" target="_blank">http://www.kitware.fr</a></font><font color="#888888"><a href="http://www.kitware.fr/" target="_blank"></a></font><br>