<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div>Ok,<br><br>I have restored the original code but I cannot reproduce the error again. Probably I spoke too soon (and opened a mantis bug issue too soon too). I'm sorry, next time I'll be more mindful. Can someone remove or close the bug issue from mantis? Thanks.<br><br>- AGPX<br></div><div style="font-family: arial,helvetica,sans-serif; font-size: 10pt;"><br><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;"><font face="Tahoma" size="2"><hr size="1"><b><span style="font-weight: bold;">Da:</span></b> Dave Partyka <dave.partyka@kitware.com><br><b><span style="font-weight: bold;">A:</span></b> AGPX <agpxnet@yahoo.it><br><b><span style="font-weight: bold;">Cc:</span></b> John Drescher <drescherjm@gmail.com>; vtk vtk <vtkusers@vtk.org><br><b><span
style="font-weight: bold;">Inviato:</span></b> Ven 26 marzo 2010, 14:09:24<br><b><span style="font-weight: bold;">Oggetto:</span></b> Re: [vtkusers] New crash bug! This time in vtkSeedWidget!<br></font><br>I can commit this, but before I do, can anyone tell me if this case is reproducible in a current test (I don't see it failing on the dashboard so it probably doesn't have any testing coverage) or willing to provide a simple test the reproduces this.<br>
<br><div class="gmail_quote">On Fri, Mar 26, 2010 at 8:58 AM, AGPX <span dir="ltr"><<a rel="nofollow" ymailto="mailto:agpxnet@yahoo.it" target="_blank" href="mailto:agpxnet@yahoo.it">agpxnet@yahoo.it</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div style="font-family: Courier New,courier,monaco,monospace,sans-serif; font-size: 10pt;"><div>Hi,<br><br>just now, at the following link:<br><br><a rel="nofollow" target="_blank" href="http://public.kitware.com/cgi-bin/viewcvs.cgi/Widgets/vtkSeedWidget.cxx?view=markup">http://public.kitware.com/cgi-bin/viewcvs.cgi/Widgets/vtkSeedWidget.cxx?view=markup</a><br>
</div><div style="font-family: Courier New,courier,monaco,monospace,sans-serif; font-size: 10pt;"><br>that bug isn't fixed.<br><div class="hm"><br><br></div><div style="font-family: arial,helvetica,sans-serif; font-size: 13px;">
<div class="hm"><font face="Tahoma" size="2"><hr size="1"><b><span style="font-weight: bold;">Da:</span></b> John Drescher <<a rel="nofollow" ymailto="mailto:drescherjm@gmail.com" target="_blank" href="mailto:drescherjm@gmail.com">drescherjm@gmail.com</a>><br><b><span style="font-weight: bold;">A:</span></b> AGPX <<a rel="nofollow" ymailto="mailto:agpxnet@yahoo.it" target="_blank" href="mailto:agpxnet@yahoo.it">agpxnet@yahoo.it</a>><br>
<b><span style="font-weight: bold;">Cc:</span></b> vtk vtk <<a rel="nofollow" ymailto="mailto:vtkusers@vtk.org" target="_blank" href="mailto:vtkusers@vtk.org">vtkusers@vtk.org</a>><br><b><span style="font-weight: bold;">Inviato:</span></b> Ven 26 marzo 2010, 13:53:50<br>
<b><span style="font-weight: bold;">Oggetto:</span></b> Re: [vtkusers] New crash bug! This time in vtkSeedWidget!<br></font></div><div><div></div><div class="h5"><br>On Fri, Mar 26, 2010 at 8:42 AM, AGPX <<a rel="nofollow" ymailto="mailto:agpxnet@yahoo.it" target="_blank" href="mailto:agpxnet@yahoo.it">agpxnet@yahoo.it</a>> wrote:<br>
> Hi guys'n'gals,<br>><br>> The method DeleteSeed of the class vtkSeedWidget crash:<br>><br>> void vtkSeedWidget::DeleteSeed(int i)<br>> {<br>> if( this->Seeds->size() <= static_cast< size_t >(i) )<br>
> {<br>> return;<br>> }<br>><br>> vtkSeedRepresentation *rep =<br>> static_cast<vtkSeedRepresentation*>(this->WidgetRep);<br>> if (rep)<br>> {<br>> rep->RemoveHandle( i );<br>
>
}<br>><br>> vtkSeedListIterator iter = this->Seeds->begin();<br>> vtkstd::advance(iter,i);<br>> (*iter)->SetEnabled(0);<br>> (*iter)->RemoveObservers(vtkCommand::StartInteractionEvent);<br>
> (*iter)->RemoveObservers(vtkCommand::InteractionEvent);<br>> (*iter)->RemoveObservers(vtkCommand::EndInteractionEvent);<br>> vtkHandleWidget * w = (*iter);<br>> this->Seeds->erase( iter );<br>
> w->Delete();<br>> }<br>><br>> The problem is in the last two lines. You have to FIRST delete the object,<br>> then erase the relative iterator. That is you have to swap the last two<br>> lines:<br>
><br>> w->Delete();<br>> this->Seeds->erase( iter );<br>><br>> Please fix it! Thanks.<br>><br>> - AGPX<br>><br>This is fixed in cvs.<br><br>John<br></div></div></div></div>
</div><br>
</div><br>_______________________________________________<br>
Powered by <a rel="nofollow" target="_blank" href="http://www.kitware.com">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a rel="nofollow" target="_blank" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the VTK FAQ at: <a rel="nofollow" target="_blank" href="http://www.vtk.org/Wiki/VTK_FAQ">http://www.vtk.org/Wiki/VTK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a rel="nofollow" target="_blank" href="http://www.vtk.org/mailman/listinfo/vtkusers">http://www.vtk.org/mailman/listinfo/vtkusers</a><br>
<br></blockquote></div><br>
</div></div>
</div><br>
</body></html>