<div>Hi,</div><div><br></div><div>I will fix those files up, it looks like it was a simple error in the declaration order that didn't produce a compilation error anywhere that was tested. Sorry about that - is there a nightly dashboard this will/should be showing up on? Thanks for reporting these issues.</div>
<div><br></div><div>Marcus</div>--<br clear="all">Marcus D. Hanwell, Ph.D.<br>R&D Engineer, Kitware Inc.<br>(518) 881-4937<br><br><div class="gmail_quote">On Wed, Jul 28, 2010 at 1:59 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com">david.gobbi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi Michael,<br>
<br>
I've pushed the vtkTIFFReader fix. I'm forwarding bug<br>
<a href="http://public.kitware.com/Bug/view.php?id=11052" target="_blank">http://public.kitware.com/Bug/view.php?id=11052</a> to Marcus because he<br>
probably has some idea about why that anonymous namespace is used in<br>
vtkPlotBar.cxx.<br>
<br>
David<br>
<br>
<br>
On Wed, Jul 28, 2010 at 11:33 AM, Michael Jackson<br>
<div><div></div><div class="h5"><<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
> I had just put a #if 0 ... #endif around the code because I was not sure<br>
> what the "correct" fix was. Simply deleting the functions will achieve the<br>
> same thing.<br>
><br>
> If you can take a look at the other bug it also proposes some fixes for<br>
> clang compile errors.<br>
><br>
> Thanks<br>
> ___________________________________________________________<br>
> Mike Jackson <a href="http://www.bluequartz.net" target="_blank">www.bluequartz.net</a><br>
> Principal Software Engineer <a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a><br>
> BlueQuartz Software Dayton, Ohio<br>
><br>
><br>
><br>
> On Jul 28, 2010, at 1:23 PM, David Gobbi wrote:<br>
><br>
>> Did you try the fix that I suggested, i.e. just removing those two<br>
>> functions? If that works, then I can commit the fix immediately.<br>
>><br>
>> I should probably get clang, so that I can test code against it<br>
>> myself. I'm not fond of xcode, but clang is probably going to become<br>
>> a more and more common compiler as time goes on.<br>
>><br>
>> David<br>
>><br>
>><br>
>> On Wed, Jul 28, 2010 at 11:12 AM, Michael Jackson<br>
>> <<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
>>><br>
>>> I filed bug <a href="http://public.kitware.com/Bug/view.php?id=11051" target="_blank">http://public.kitware.com/Bug/view.php?id=11051</a> for this<br>
>>> issue<br>
>>> and <a href="http://public.kitware.com/Bug/view.php?id=11052" target="_blank">http://public.kitware.com/Bug/view.php?id=11052</a> for a related issue.<br>
>>> I<br>
>>> don't have git commit access so I am hoping someone else can do that<br>
>>> part.<br>
>>><br>
>>> I'll hopefully be submitting an experimental dashboard within the hour<br>
>>> with<br>
>>> the complete compile/test results for VTK.<br>
>>><br>
>>> I think I was on the actual VTK 5.6 release from GIT.<br>
>>> ___________________________________________________________<br>
>>> Mike Jackson <a href="http://www.bluequartz.net" target="_blank">www.bluequartz.net</a><br>
>>><br>
>>><br>
>>> On Jul 28, 2010, at 1:04 PM, David Gobbi wrote:<br>
>>><br>
>>>> Do you mean VTK git master? There's a difference between VTK 5.6 and<br>
>>>> the latest VTK from git.<br>
>>>><br>
>>>> I think that vtkTIFFReader.cxx has some old templated functions inside<br>
>>>> of it that aren't used anymore. The right way to patch the file would<br>
>>>> be to simply remove those functions (ReadTiledImage and<br>
>>>> ReadScanlineImage) completely.<br>
>>>><br>
>>>> David<br>
>>>><br>
>>>><br>
>>>> On Wed, Jul 28, 2010 at 10:23 AM, Michael Jackson<br>
>>>> <<a href="mailto:mike.jackson@bluequartz.net">mike.jackson@bluequartz.net</a>> wrote:<br>
>>>>><br>
>>>>> I am getting the following compiler error for VTK 5.6<br>
>>>>><br>
>>>>> [ 57%] /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.cxx:811:19: error:<br>
>>>>> 'EvaluateImageAt' is a protected<br>
>>>>> member of 'vtkTIFFReader'<br>
>>>>> self->EvaluateImageAt(image+imagepos,<br>
>>>>> static_cast<T*>(buffer)+tilepos);<br>
>>>>> ^<br>
>>>>> In file included from<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.cxx:15:<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.h:116:7: note: declared<br>
>>>>> protected here<br>
>>>>> int EvaluateImageAt( void*, void* );<br>
>>>>> ^<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.cxx:829:47: error:<br>
>>>>> 'GetInternalImage' is a protected<br>
>>>>> member of 'vtkTIFFReader'<br>
>>>>> unsigned int isize =<br>
>>>>> TIFFScanlineSize(self->GetInternalImage()->Image);<br>
>>>>> ^<br>
>>>>> In file included from<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.cxx:15:<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.h:114:26: note: declared<br>
>>>>> protected here<br>
>>>>> vtkTIFFReaderInternal *GetInternalImage() { return<br>
>>>>> this->InternalImage;<br>
>>>>> }<br>
>>>>> ^<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.cxx:852:21: error:<br>
>>>>> 'EvaluateImageAt' is a protected<br>
>>>>> member of 'vtkTIFFReader'<br>
>>>>> inc = self->EvaluateImageAt( image,<br>
>>>>> ^<br>
>>>>> In file included from<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.cxx:15:<br>
>>>>> /Users/Shared/OpenSource/VTK/IO/vtkTIFFReader.h:116:7: note: declared<br>
>>>>> protected here<br>
>>>>> int EvaluateImageAt( void*, void* );<br>
>>>>> ^<br>
>>>>><br>
>>>>> Looking at where those errors occur reveals that they are in template<br>
>>>>> functions inside of ReadTiledImage and ReadScanlineImage in the<br>
>>>>> vtkTIFFReader.cxx file. These functions appear never to be used<br>
>>>>> anywhere<br>
>>>>> in<br>
>>>>> the code but if they _do_ get used then a compile error will be thrown<br>
>>>>> at<br>
>>>>> that point. The functions probably need to be moved to the<br>
>>>>> vtkTIFFReader.h<br>
>>>>> file instead of in the vtkTIFFReader.cxx file or the functions need to<br>
>>>>> be<br>
>>>>> removed if they are not being used at all.<br>
>>>>><br>
>>>>> If the vtk-devs are ok with that I can submit a patch for someone to<br>
>>>>> commit.<br></div></div></blockquote></div>