<div dir="ltr">Marcus approved it, but Joachim didn't merge it. My guess is that Gerrit's notification was lost in the email background noise.<div><br><div>Approved developers should merge there own changes once someone else approves. That way the original developer knows when to pay especially close attention to the continuous and nightly dashboards.<div>
<br><div><div>I merged it just now. Joachim, please keep an eye out today and tomorrow.<br></div></div></div></div></div><div class="gmail_extra"><br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>
21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a></div>
<br><br><div class="gmail_quote">On Thu, Nov 14, 2013 at 2:39 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Lars,<br>
<br>
Thanks for the note. A patch for this was approved two weeks ago, but<br>
for some reason it was not merged yet:<br>
<a href="http://review.source.kitware.com/#/c/13199/" target="_blank">http://review.source.kitware.com/#/c/13199/</a><br>
<br>
Hopefully someone will read this email and push the "submit" button to<br>
merge this patch into master :)<br>
<span><font color="#888888"><br>
David<br>
</font></span><div><div><br>
<br>
<br>
<br>
On Thu, Nov 14, 2013 at 12:21 PM, Lars Matthäus <<a href="mailto:lars.matthaeus@web.de" target="_blank">lars.matthaeus@web.de</a>> wrote:<br>
> Dear all,<br>
><br>
> I'm facing build issues with the current master branch using Visual<br>
> Studio 2013 (aka Visual Studio 12) and compiling 64 bit.<br>
><br>
> I get error messages like<br>
><br>
> error C2039: 'max' : is not a member of 'std'<br>
> VTK\Common\Core\vtkUnicodeStringArray.cxx 133<br>
> error C3861: 'max': identifier not found<br>
> VTK\Common\Core\vtkUnicodeStringArray.cxx 133<br>
> error C2039: 'min' : is not a member of 'std'<br>
> VTK\Filters\Core\vtkCutter.cxx 826<br>
> error C3861: 'min': identifier not found<br>
> IVTK\Filters\Core\vtkCutter.cxx 826 1 vtkFiltersCore<br>
><br>
> All in all, it affects 16 files:<br>
> Charts\Core\vtkContextPolygon.cxx<br>
> Charts\Core\vtkPiecewisePointHandleItem.cxx<br>
> Common\Core\vtkUnicodeStringArray.cxx<br>
> Common\DataModel\vtkMappedUnstructuredGrid.txx<br>
> Filters\Core\vtkCutter.cxx<br>
> Filters\Core\vtkThreshold.cxx<br>
> Filters\General\vtkNormalizeMatrixVectors.cxx<br>
> Filters\Imaging\vtkPairwiseExtractHistogram2D.cxx<br>
> IO\Geometry\vtkMoleculeReaderBase.cxx<br>
> Infovis\Core\vtkAdjacencyMatrixToEdgeTable.cxx<br>
> Infovis\Layout\vtkIncrementalForceLayout.cxx<br>
> Rendering\Context2D\vtkMarkerUtilities.cxx<br>
> Rendering\Core\vtkTextMapper.cxx<br>
> Rendering\FreeType\vtkMathTextUtilities.cxx<br>
> Rendering\FreeType\vtkTextActor.cxx<br>
> Views\Infovis\vtkParallelCoordinatesRepresentation.cxx<br>
><br>
><br>
> But if I include algorithm (#include <algorithm>) in each cxx,<br>
> everything compiles and runs just fine.<br>
><br>
> Am I missing any settings or do others experience the same?<br>
><br>
> Thanks,<br>
> Lars<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the VTK FAQ at: <a href="http://www.vtk.org/Wiki/VTK_FAQ" target="_blank">http://www.vtk.org/Wiki/VTK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtkusers" target="_blank">http://www.vtk.org/mailman/listinfo/vtkusers</a><br>
</div></div></blockquote></div><br></div></div>