<div dir="ltr">Thank you Jerome!<div><br></div><div>I've added some reviewers who according to the git log are knowledgable about this particular file and we'll see about getting it in.</div><div class="gmail_extra">
<br clear="all"><div>David E DeMarle<br>Kitware, Inc.<br>R&D Engineer<br>21 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: <a href="tel:518-881-4909" value="+15188814909" target="_blank">518-881-4909</a></div>
<br><br><div class="gmail_quote">On Thu, Jan 9, 2014 at 11:30 AM, Jerome Robert <span dir="ltr"><<a href="mailto:jeromerobert@gmx.com" target="_blank">jeromerobert@gmx.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Done as <a href="http://review.source.kitware.com/#/t/3826/" target="_blank">http://review.source.kitware.com/#/t/3826/</a><br>
<br>
Jerome<br>
<br>
> ----- Message d'origine -----<br>
> De : David E DeMarle<br>
> Envoyés : 09.01.14 15:59<br>
> À : Jerome Robert<br>
> Objet : Re: [vtkusers] Java and Mingw, library naming problem<br>
<div>><br>
> Mind sending that patch though gerrit? I know the patch is trivial to<br>
> apply, but submitting it through gerrit vastly simplifies regression<br>
> testing. That makes it much more likely that it will be merged in.<br>
><br>
> See: <a href="http://www.vtk.org/Wiki/VTK/Git/Develop" target="_blank">http://www.vtk.org/Wiki/VTK/Git/Develop</a><br>
><br>
><br>
</div><div>> On Thu, Jan 9, 2014 at 9:51 AM, Jerome Robert <<a href="mailto:jeromerobert@gmx.com" target="_blank">jeromerobert@gmx.com</a>> wrote:<br>
><br>
> > Hi all,<br>
> ><br>
> > Unless I missed something the following bugs:<br>
> ><br>
> > - <a href="http://vtk.org/Bug/view.php?id=10969" target="_blank">http://vtk.org/Bug/view.php?id=10969</a><br>
> > - <a href="http://vtk.org/Bug/view.php?id=7589" target="_blank">http://vtk.org/Bug/view.php?id=7589</a><br>
> ><br>
> > are still there in vtk 6.1.0rc1 and they could be fixed using the<br>
> > following patch:<br>
> ><br>
> > diff --git a/CMake/vtkJavaWrapping.cmake b/CMake/vtkJavaWrapping.cmake<br>
> > index 8596892..0509cae 100644<br>
> > --- a/CMake/vtkJavaWrapping.cmake<br>
> > +++ b/CMake/vtkJavaWrapping.cmake<br>
> > @@ -41,6 +41,9 @@ function(vtk_add_java_wrapping module_name module_srcs<br>
> > module_hdrs)<br>
> > "${module_srcs};${Kit_JAVA_EXTRA_WRAP_SRCS}")<br>
> ><br>
> > add_library(${module_name}Java SHARED ${ModuleJava_SRCS}<br>
> > ${Kit_JAVA_EXTRA_SRCS})<br>
> > + if(MINGW)<br>
> > + set_target_properties(${module_name}Java PROPERTIES PREFIX "")<br>
> > + endif(MINGW)<br>
> > vtk_target_export(${module_name}Java)<br>
> > if(CMAKE_HAS_TARGET_INCLUDES)<br>
> > set_property(TARGET ${module_name}Java APPEND<br>
> ><br>
<br>
</div><div><div>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the VTK FAQ at: <a href="http://www.vtk.org/Wiki/VTK_FAQ" target="_blank">http://www.vtk.org/Wiki/VTK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtkusers" target="_blank">http://www.vtk.org/mailman/listinfo/vtkusers</a><br>
</div></div></blockquote></div><br></div></div>