MantisBT - VTK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010059VTK(No Category)public2009-12-16 22:202013-04-05 19:57
Reporterhfxt 
Assigned ToFrançois Bertel 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Project
Type
Summary0010059: vtk 5.5 ; dead loop
Descriptionwhen comparing two float number,it should not use "==";

VTK\Common\vtkAbstractTransform.cxx
Line 534
Line 553
Line 605
VTK\Common\vtkBox.cxx
Line 46
Line 73
Line 88
..........

many places found.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-16 22:20hfxtNew Issue
2009-12-28 06:12François BertelStatusbacklog => tabled
2009-12-28 06:12François BertelAssigned To => François Bertel
2009-12-28 06:18François BertelNote Added: 0018997
2009-12-28 07:33hfxtNote Added: 0018998
2009-12-30 05:58François BertelNote Added: 0019015
2009-12-30 05:58François BertelStatustabled => @80@
2009-12-30 05:58François BertelResolutionopen => fixed
2011-06-16 13:11Zack GalbreathCategory => (No Category)
2013-04-05 19:57Berk GeveciStatuscustomer review => closed

Notes
(0018997)
François Bertel   
2009-12-28 06:18   
The use of == in the lines you listed is perfectly valid.

There are not comparing an expected value to a result of a computation (which should be done with something like fabs(a-b)<someEpsilon) but
compare values to previous assigned values to prevent call to Modified().

The summary for this bug report does not make sense. How it is relevant to the note you added? What is the dead loop you are talking about?
(0018998)
hfxt   
2009-12-28 07:33   
Graphics\vtkStreamer.cxx
when i compute streamline,it has a vortex(unlimited curve)
L383 d==0
it should be "d<=someEpsilon",break loop as soon as possible.
(0019015)
François Bertel   
2009-12-30 05:58   
Fixed in revision 1.65 of vtkStreamer.h and revision 1.93 of vtkStreamer.cxx on 2009-12-30 in CVS HEAD (VTK 5.5).