MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010908ParaViewFeaturepublic2010-06-29 10:312011-09-01 13:31
ReporterSven Buijssen 
Assigned ToDavid Partyka 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionDevelopment 
Target VersionFixed in Version3.12 
Project
Topic Name
Type
Summary0010908: Update labels of reader objects in pipeline browser when replacing files while loading state file
Descriptioncommit 8f3fe99a23c9fdb74cff7d3c2a374fa157239c68 added dialog to prompt to change filenames while loading a state file.

Currently, the labels displayed in the pipeline browser are preserved, regardless whether one replaces or keeps the file names stored in the state file. That does make sense if a user has altered it prior to saving a state file, i.e. display name != basename(file name). But in case the user hasn't, it would be very convenient if the label in the pipeline browser would get updated with the new file name.

Maybe it is best to let the user decide by presenting him a checkbox in the change filename dialog.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-29 10:31Sven BuijssenNew Issue
2010-08-05 13:45Utkarsh AyachitStatusbacklog => tabled
2010-08-05 13:45Utkarsh AyachitAssigned To => David Partyka
2010-08-05 13:52Utkarsh AyachitNote Added: 0021668
2010-09-22 17:46David PartykaNote Added: 0022324
2010-09-22 17:46David PartykaNote Deleted: 0022324
2010-09-22 17:46David PartykaNote Added: 0022325
2010-09-22 17:46David PartykaStatustabled => @80@
2010-09-22 17:46David PartykaFixed in Version => Development
2010-09-22 17:46David PartykaResolutionopen => fixed
2010-10-15 21:02Alan ScottNote Added: 0022505
2010-10-15 21:02Alan ScottStatus@80@ => closed
2011-06-16 13:10Zack GalbreathCategoryFeature Request => Feature
2011-09-01 13:31Utkarsh AyachitFixed in VersionDevelopment => 3.12

Notes
(0021668)
Utkarsh Ayachit   
2010-08-05 13:52   
Qt/Components/pqFixStateFilenamesDialog is the dialog that gets popped up when a state file is loaded. In this dialog, in the constructor, the state xml is parsed and a data-structure is created that has the reader-xml dom elements. These are then later updated when the filename is changed by the user.

In the state xml all source proxies (include readers) are present in xml as follows:
 ...
 <ProxyCollection name="sources">
      <Item id="136" name="Sphere1"/>
      ....
    </ProxyCollection>
  ...

The name here is the name that the source/reader shows up as in the GUI. Now the parsing code will have to locate and keep track of these elements associated with the reader. So when the filename changes, it can update the registration name as well.
(0022325)
David Partyka   
2010-09-22 17:46   
This should be fixed on master in commit d62df76b9d6ae7fc0dee403ea2770d95106e9147. Please report if there are any more issues.
(0022505)
Alan Scott   
2010-10-15 21:02   
Trusting Utkarsh.