MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011572ParaViewBugpublic2010-12-06 05:092015-01-02 10:45
ReporterSven Buijssen 
Assigned ToDavid Partyka 
PrioritylowSeveritytweakReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Version3.8.1 
Target VersionFixed in Version4.3 
Project
Topic Name
Type
Summary0011572: Canceling the FixStateFilenamesDialog does not cancel state loading
DescriptionLoad a state file that contains a reference to a reader
pqFixStateFilenamesDialog.ui will pop up
Hit Cancel
=> PV will load the state file ignoring any change made in the dialog to the reader file name(s).

Suggestion: Instead of naming the button "Cancel", name it "Revert". Then there is no need to implement a pqFixStateFilenamesDialog::cancelled and the user would know what to expect when pressing this button.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-06 05:09Sven BuijssenNew Issue
2011-01-06 22:07David PartykaAssigned To => David Partyka
2011-01-06 22:07David PartykaStatusbacklog => tabled
2011-01-19 10:41Utkarsh AyachitNote Added: 0024914
2014-10-10 10:34Cory QuammenNote Added: 0033625
2014-10-10 10:34Cory QuammenStatusbacklog => gatekeeper review
2014-10-10 10:34Cory QuammenResolutionopen => no change required
2014-10-15 10:08Utkarsh AyachitFixed in Version => git-master
2014-10-15 10:08Utkarsh AyachitStatusgatekeeper review => customer review
2014-10-15 10:08Utkarsh AyachitNote Added: 0033646
2014-11-06 20:17Alan ScottNote Added: 0033773
2014-11-06 20:17Alan ScottStatuscustomer review => closed
2015-01-02 10:45Utkarsh AyachitFixed in Versiongit-master => 4.3

Notes
(0024914)
Utkarsh Ayachit   
2011-01-19 10:41   
I think I like Sven's suggestion to rename the button. The way the implementation is done, it's very hard to actually cancel the loading.
(0033625)
Cory Quammen   
2014-10-10 10:34   
The "Cancel" button seems to have been renamed to "Discard", which is close to Sven's suggestion.
(0033646)
Utkarsh Ayachit   
2014-10-15 10:08   
Topics merged into master:
        15025_fix_annotations
        15035_reverse_connections_dsrs
        15043_add_qmake_variable_back
        15044_update_example_plugins
        cmake-cmp0053-warnings
        live-breakpoint
        pv-plot-bar-lut
        visible_range
(0033773)
Alan Scott   
2014-11-06 20:17   
Closing.