MantisBT - VTK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012326VTK(No Category)public2011-07-01 09:042013-04-05 20:27
ReporterThomas F Albrecht 
Assigned ToKyle Lutz 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
ProjectTBD
Typeincorrect functionality
Summary0012326: vtkXMLCompositeDataWriter does not write blocks with PolyData
DescriptionPolyData blocks are not written, because of this code in line 590ff:

  vtkstd::string fname;
  if(this->Internal->DataTypes[piece] <= 0)
    {
    return fname;
    }

PolyData has DataType 0, so instead of just discarding invalid DataTypes with values < 0 by returning only the name, the same is done for PolyData.

This is easily fixed by replacing by:

  if(this->Internal->DataTypes[piece] <= 0)

Then, everything works fine.

In the attached file, the bug is fixed, yet marked with a "FIXME" tag.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filescxx vtkXMLCompositeDataWriter.cxx (20,795) 2011-07-01 09:04
https://www.vtk.org/Bug/file/8968/vtkXMLCompositeDataWriter.cxx
Issue History
Date ModifiedUsernameFieldChange
2011-07-01 09:04Thomas F AlbrechtNew Issue
2011-07-01 09:04Thomas F AlbrechtFile Added: vtkXMLCompositeDataWriter.cxx
2011-07-01 09:30Utkarsh AyachitAssigned To => Kyle Lutz
2011-07-01 09:30Utkarsh AyachitStatusbacklog => todo
2011-07-01 09:35Thomas F AlbrechtNote Added: 0026937
2011-07-01 09:56Thomas F AlbrechtNote Added: 0026938
2011-07-01 10:12Kyle LutzStatustodo => active development
2011-07-01 10:19Kyle LutzNote Added: 0026939
2011-07-01 10:19Kyle LutzStatusactive development => gatekeeper review
2011-07-08 16:26Utkarsh AyachitStatusgatekeeper review => customer review
2013-04-05 20:27Berk GeveciStatuscustomer review => closed
2013-04-05 20:27Berk GeveciResolutionopen => fixed

Notes
(0026937)
Thomas F Albrecht   
2011-07-01 09:35   
Ooops, I didn't fill out the Reproducibility, which is of course: always.
(0026938)
Thomas F Albrecht   
2011-07-01 09:56   
Another mistake: Of course the replacement should be:

  if(this->Internal->DataTypes[piece] < 0)

(without the equal sign)
(0026939)
Kyle Lutz   
2011-07-01 10:19   
This bug was fixed by the following commit:

commit 99b3c8823d2fc09ef1a64bbc3f257274ee3ecb52
Author: Pierre Fillard <pierre.fillard@gmail.com>
Date: Mon Dec 6 15:10:44 2010 -0500

    BUG: Fixed an issue where vtkPolydata wasn't being written to file.
    
    The polydata enum value was zero which caused composite data with polydata to fail to be written properly.