MantisBT - ParaView |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0012398 | ParaView | (No Category) | public | 2011-07-25 09:04 | 2011-07-29 16:16 |
|
| Reporter | Sebastien Jourdain | |
| Assigned To | Sebastien Jourdain | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.12 | |
| Project | Collaboration |
| Topic Name | 12398-VisTrails-fix |
| Type | incorrect functionality |
|
| Summary | 0012398: VisTrails plugin recording too much informations before state loading action |
| Description | Our plugin is nearly complete, however there is an issue when a user loads a ParaView save file. The problem is that a few UndoSets get pushed onto the UndoStack before the aboutToLoadState() signal is emitted, so we end up recording actions we don't want. I can think of two simple solutions for this, but both require very minor changes to the ParaView source.
Solution 1: In the loadState() method at pqApplicationCore.cxx::519, move the emit this->aboutToLoadState(rootElement) call up 5 lines before the pqViews are destroyed. This way we can detect that the state is loading earlier and ignore the changes to the UndoStack.
Solution 2: Add BEGIN_UNDO_EXCLUDE() and END_UNDO_EXCLUDE() calls around the code that destroys the pqViews near pqApplicationCore.cxx::511 ~ 518. This shouldn't cause any problems in ParaView because the UndoStack is cleared when the ProxyManager loads the state anyway.
>>> We have chosen solution 2 |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2011-07-25 09:04 | Sebastien Jourdain | New Issue | |
| 2011-07-25 09:04 | Sebastien Jourdain | Assigned To | => Sebastiennn Jourdain |
| 2011-07-25 09:11 | Sebastien Jourdain | Status | backlog => todo |
| 2011-07-25 09:12 | Sebastien Jourdain | Status | todo => active development |
| 2011-07-25 09:20 | Sebastien Jourdain | Topic Name | => 12398-VisTrails-fix |
| 2011-07-25 09:20 | Sebastien Jourdain | Note Added: 0027072 | |
| 2011-07-25 09:20 | Sebastien Jourdain | Status | active development => gatekeeper review |
| 2011-07-25 09:20 | Sebastien Jourdain | Resolution | open => fixed |
| 2011-07-29 10:40 | Utkarsh Ayachit | Note Added: 0027124 | |
| 2011-07-29 10:42 | Utkarsh Ayachit | Fixed in Version | => 3.12 |
| 2011-07-29 12:33 | Dave DeMarle | Note Added: 0027136 | |
| 2011-07-29 15:03 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
| 2011-07-29 15:03 | Utkarsh Ayachit | Note Added: 0027155 | |
| 2011-07-29 16:16 | Utkarsh Ayachit | Status | customer review => closed |
|
Notes |
|
|
(0027072)
|
|
Sebastien Jourdain
|
|
2011-07-25 09:20
|
|
|
Solution has been push to stage and merged to next |
|
|
|
(0027124)
|
|
Utkarsh Ayachit
|
|
2011-07-29 10:40
|
|
|
Issue slated for Gatekeeper review on Jul 29, 2 pm EDT. |
|
|
|
(0027136)
|
|
Dave DeMarle
|
|
2011-07-29 12:33
|
|
|
verified - at least in so far as looking at the code |
|
|
|
(0027155)
|
|
Utkarsh Ayachit
|
|
2011-07-29 15:03
|
|
|
Merged to master (if applicable) |
|