MantisBT - ParaView |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0012905 | ParaView | (No Category) | public | 2012-02-01 16:24 | 2012-02-08 17:24 |
|
| Reporter | David Doria | |
| Assigned To | Robert Maynard | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 3.12 | |
| Target Version | | Fixed in Version | 3.14 | |
| Project | TBD |
| Topic Name | 12905-postfilter-magnitude-is-double |
| Type | usability |
|
| Summary | 0012905: Type of automatically computed magnitude should be large enough to not overflow |
| Description | The magnitude that is automatically computed for the ThresholdFilter (which turns an array Colors into a magnitude array Colors_Magnitude) is stored as the same type as the array. That is, the magnitude of an unsigned char array (255,255,255) is stored as an unsigned char is which overflows to 185 instead of being correctly 441.
Using a double can still have problems (as the components approach double_max
you run into generate INF or rolling over), but it should always be better than using the same type as the array components.
|
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | child of | 0012904 | closed | Robert Maynard | Auto Convert properties fail on Magnitude |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-02-01 16:24 | David Doria | New Issue | |
| 2012-02-02 09:33 | Robert Maynard | Assigned To | => Robert Maynard |
| 2012-02-02 09:33 | Robert Maynard | Status | backlog => todo |
| 2012-02-02 09:33 | Robert Maynard | Relationship added | child of 0012904 |
| 2012-02-02 09:33 | Robert Maynard | Status | todo => active development |
| 2012-02-02 11:55 | Robert Maynard | Topic Name | => 12905-postfilter-magnitude-is-double |
| 2012-02-02 11:55 | Robert Maynard | Note Added: 0028014 | |
| 2012-02-02 11:55 | Robert Maynard | Status | active development => gatekeeper review |
| 2012-02-02 11:55 | Robert Maynard | Resolution | open => fixed |
| 2012-02-03 15:06 | Utkarsh Ayachit | Note Added: 0028035 | |
| 2012-02-03 15:06 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
| 2012-02-03 15:06 | Utkarsh Ayachit | Note Added: 0028047 | |
| 2012-02-03 15:07 | Utkarsh Ayachit | Fixed in Version | => git-master |
| 2012-02-08 17:21 | Utkarsh Ayachit | Fixed in Version | git-master => 3.14 |
| 2012-02-08 17:24 | Utkarsh Ayachit | Status | customer review => closed |
| 2012-02-08 17:24 | Utkarsh Ayachit | Note Added: 0028131 | |
|
Notes |
|
|
(0028014)
|
|
Robert Maynard
|
|
2012-02-02 11:55
|
|
|
Now all magnitude arrays that are generated in vtkPVPostFilter are double arrays. |
|
|
|
(0028035)
|
|
Utkarsh Ayachit
|
|
2012-02-03 15:06
|
|
|
merged into master, where applicable. |
|
|
|
(0028047)
|
|
Utkarsh Ayachit
|
|
2012-02-03 15:06
|
|
|
merged into master, where applicable. |
|
|
|
(0028131)
|
|
Utkarsh Ayachit
|
|
2012-02-08 17:24
|
|
|
Closing bugs sitting in "customer review" for a long time. |
|