MantisBT - VTK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012979VTK(No Category)public2012-03-05 12:582013-12-16 13:22
Reporterdomibel 
Assigned ToAndy Bauer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
ProjectTBD
Typecrash
Summary0012979: VTK/Parallel/vtkPNetCDFPOPReader.cxx doesn't compile using a standard netcdf installation
DescriptionI am running into the following compiler error if I use a system netcdf installation. Is this a bug in netcdf or vtk?

[ 72%] Building CXX object Parallel/CMakeFiles/vtkParallel.dir/vtkPNetCDFPOPReader.cxx.o
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx:39:6: error: #error MPI_Comm is #define'd somewhere! That's BAD! (Try checking netcdf.h.)
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx: In member function ‘virtual int vtkPNetCDFPOPReader::RequestData(vtkInformation*, vtkInformationVector**, vtkInformationVector*)’:
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx:474:115: error: cannot convert ‘ompi_communicator_t**’ to ‘int*’ in initialization
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx:476:100: error: invalid conversion from ‘int’ to ‘MPI_Comm {aka ompi_communicator_t*}’ [-fpermissive]
/usr/lib/openmpi/include/mpi.h:1136:20: error: initializing argument 6 of ‘int MPI_Irecv(void*, int, MPI_Datatype, int, int, MPI_Comm, ompi_request_t**)’ [-fpermissive]
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx: In member function ‘int vtkPNetCDFPOPReader::ReadAndSend(vtkInformation*, int)’:
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx:636:115: error: cannot convert ‘ompi_communicator_t**’ to ‘int*’ in initialization
/home/domibel/github/VTK/Parallel/vtkPNetCDFPOPReader.cxx:637:83: error: invalid conversion from ‘int’ to ‘MPI_Comm {aka ompi_communicator_t*}’ [-fpermissive]
/usr/lib/openmpi/include/mpi.h:1140:20: error: initializing argument 6 of ‘int MPI_Isend(void*, int, MPI_Datatype, int, int, MPI_Comm, ompi_request_t**)’ [-fpermissive]
make[2]: *** [Parallel/CMakeFiles/vtkParallel.dir/vtkPNetCDFPOPReader.cxx.o] Error 1
make[1]: *** [Parallel/CMakeFiles/vtkParallel.dir/all] Error 2
make: *** [all] Error 2

Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-05 12:58domibelNew Issue
2012-03-06 12:37Andy BauerAssigned To => Andy Bauer
2012-03-06 12:37Andy BauerStatusbacklog => tabled
2012-03-06 13:02Andy BauerNote Added: 0028341
2012-03-07 09:34domibelNote Added: 0028342
2012-03-07 09:58Andy BauerNote Added: 0028343
2012-03-07 10:31domibelNote Added: 0028344
2013-07-22 20:02Dave DeMarleStatustabled => backlog
2013-07-22 20:02Dave DeMarleNote Added: 0031254
2013-12-16 13:22Dave DeMarleNote Added: 0031947
2013-12-16 13:22Dave DeMarleStatusbacklog => closed

Notes
(0028341)
Andy Bauer   
2012-03-06 13:02   
I don't see an option in VTK to use a separate build of NetCDF so I'm not sure how to reproduce it. If this is a problem with the NetCDF that is packaged with VTK then I should be able to fix it.
(0028342)
domibel   
2012-03-07 09:34   
Yes, there is no such option. I had to change the code to make this happen.
I am wondering why VTK is using a special patched NetCDF version.
Is it a mistake to link against a standard netcdf installation?

Isn't it better to inform the netcdf developer if you find a bug in their code?
(0028343)
Andy Bauer   
2012-03-07 09:58   
As far as I know, we don't use a patched version of netcdf. I think the reason that we have a specified version of netcdf is to ensure compatibility with our our code. If you want to make the changes to support system netcdf and can debug this issue, feel free to submit it to our gerrit review for addition to VTK.
(0028344)
domibel   
2012-03-07 10:31   
Here are the changes to VTK's netcdf

http://vtk.org/gitweb?p=VTK.git;a=history;f=Utilities/vtknetcdf;hb=01716fad5131a1d6af5e695aabc3590d2cffd788 [^]
(0031254)
Dave DeMarle   
2013-07-22 20:02   
moving all "tabled" bugs into "backlog" category since "tabled" is no longer used.
(0031947)
Dave DeMarle   
2013-12-16 13:22   
We traditional patch our TPLs to cmakeify them for windows.
In any case, we can use system netcdf in 6.1, so this particular bug is likely solved.