MantisBT - VTK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012996VTK(No Category)public2012-03-14 10:362012-03-29 16:00
Reporterleila 
Assigned ToDavid Gobbi 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
ProjectKitware
Typeincorrect functionality
Summary0012996: typing mistake
DescriptionvtkSortFileNames.cxx

line 352 is written
if (0 && (c1 >= '0' && c1 <= '9') && (c2 >= '0' && c2 <= '9'))

whereas it should be

if ((c1 >= '0' && c1 <= '9') && (c2 >= '0' && c2 <= '9'))

This results in incorrect sorting of filenames and removing the extra zero solves it.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-14 10:36leilaNew Issue
2012-03-14 15:45David GobbiNote Added: 0028358
2012-03-14 15:45David GobbiAssigned To => David Gobbi
2012-03-14 15:45David GobbiStatusbacklog => tabled
2012-03-14 15:45David GobbiResolutionopen => fixed
2012-03-29 16:00David GobbiNote Added: 0028406
2012-03-29 16:00David GobbiStatustabled => closed

Notes
(0028358)
David Gobbi   
2012-03-14 15:45   
commit ecb8ac608fc1c28f46a1d2f470e3c49ce34c6603
Author: David Gobbi <david.gobbi@gmail.com>
Date: Wed Mar 14 09:40:56 2012 -0600

BUG 0012996: Remove debug code from vtkSortFileNames.cxx.

An "if" was disabled by debug code, this should have been removed
in commit 38c8cd8a (on July 6 2006!) but was overlooked. Thanks
to Leila Baghdadi for identifying the problem.

Change-Id: I61c39acdb6ba231bc49ba9659b67a736d2841764
(0028406)
David Gobbi   
2012-03-29 16:00   
Fixed in commit ecb8ac60 (Mar 14, 2012).
Included in 5.10 release.