MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014835ParaView(No Category)public2014-06-30 16:592015-01-11 08:15
ReporterAlan Scott 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.3Fixed in Version4.3 
ProjectSandia
Topic Name14835_fix_log_scale_for_coloring
Typeincorrect functionality
Summary0014835: Color legend log minimum color is wrong
DescriptionWhen a user has positive data that is to be logged, and includes 0 or negative data, ParaView will arbitrarily change this the minimum to 1. Please add more intelligence to this algorithm. What I would like is as follows:

If (data is all positive)
  Leave algorithm as is.
else (i.e., we have 0 or negative data)
  Possible-Min = max/(1e-4)
  If (Possible-Min < 1)
    Minimum = Possible-Min
  Else
    Minimum = 1
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0014837closed Utkarsh Ayachit Color legend log ranges - advanced 
related to 0014895closed T.J. Corona 2d plots log is wrong 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-30 16:59Alan ScottNew Issue
2014-07-07 16:59Alan ScottProjectTBD => Sandia
2014-07-07 16:59Alan ScottTarget Version => 4.2
2014-07-08 12:55Alan ScottRelationship addedrelated to 0014837
2014-07-29 17:57Alan ScottRelationship addedrelated to 0014895
2014-07-31 13:08Utkarsh AyachitStatusbacklog => todo
2014-11-04 12:47Utkarsh AyachitTarget Version4.2 => bug_fix
2014-11-12 16:46Utkarsh AyachitTopic Name => 14835_fix_log_scale_for_coloring
2014-11-12 16:46Utkarsh AyachitNote Added: 0033802
2014-11-12 16:46Utkarsh AyachitStatustodo => gatekeeper review
2014-11-12 16:46Utkarsh AyachitFixed in Version => git-next
2014-11-12 16:46Utkarsh AyachitResolutionopen => fixed
2014-11-12 16:46Utkarsh AyachitAssigned To => Utkarsh Ayachit
2014-11-14 22:56Utkarsh AyachitTarget Versionbug_fix => 4.3
2014-11-15 09:56Utkarsh AyachitFixed in Versiongit-next => git-master
2014-11-15 09:57Utkarsh AyachitStatusgatekeeper review => customer review
2014-11-15 09:57Utkarsh AyachitNote Added: 0033813
2014-11-24 21:59Alan ScottNote Added: 0033840
2014-11-24 21:59Alan ScottNote Added: 0033841
2014-11-24 21:59Alan ScottStatuscustomer review => todo
2014-11-27 13:03Utkarsh AyachitNote Added: 0033863
2014-11-27 13:03Utkarsh AyachitStatustodo => gatekeeper review
2014-11-27 13:03Utkarsh AyachitFixed in Versiongit-master => git-next
2014-11-28 08:36Utkarsh AyachitNote Added: 0033864
2014-11-28 08:36Utkarsh AyachitStatusgatekeeper review => customer review
2014-11-28 08:36Utkarsh AyachitFixed in Versiongit-next => git-master
2014-12-02 15:47Alan ScottNote Added: 0033869
2014-12-02 15:47Alan ScottStatuscustomer review => closed
2015-01-02 10:43Utkarsh AyachitFixed in Versiongit-master => 4.3
2015-01-11 08:13Utkarsh AyachitSource_changeset_attached => ParaView master c7900121
2015-01-11 08:13Utkarsh AyachitSource_changeset_attached => ParaView master 21b340fb
2015-01-11 08:15Utkarsh AyachitSource_changeset_attached => ParaView master 3f57431d
2015-01-11 08:15Utkarsh AyachitSource_changeset_attached => ParaView master da670c90

Notes
(0033802)
Utkarsh Ayachit   
2014-11-12 16:46   
commit da670c90315add2646db3e940d997a7fb0519fba
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Nov 12 16:44:19 2014 -0500

    BUG 0014835: Pick better range for log coloring.
    
    When switching to using log colors, ParaView now picks a range based on
    the current range, rather than picking an arbitrary range. The logic
    used is:
    
    If (data is all positive)
        Leave algorithm as is.
    else (i.e., we have 0 or negative data)
        Possible-Min = max/(1e-4)
        If (Possible-Min < 1)
           Minimum = Possible-Min
        Else
           Minimum = 1
    
    Change-Id: I21eabc08425a2b0fba6129991a1daacd63b9c431
(0033813)
Utkarsh Ayachit   
2014-11-15 09:57   
Topics merged into master (v4.2.0-133-g7e996c8)
        0015121_fix_ambient_diffuse
        14835_fix_log_scale_for_coloring
(VTK) 15101_fix_particlepath
        15126_fix_properties_panel
        15128_fix_output_window_on_Windows
(VTK) adios-buffer-resizing
        cmake-warnings-20140922
        fix-COPYONLY-usage
        osx-deprecation-warnings
        remove-else-and-endfoo-cmake-args
(VTK) update-vtk-20141114
(0033840)
Alan Scott   
2014-11-24 21:59   
Oh, so very very close.

Normal works:
* Linux, master.
* Disk_out_ref.exo, all vars on, apply.
* Color by temp. Change range to [0,913] or [-1,913]. Edit Color Map. Use log scale when mapping data to colors.
* Works correctly.

Fails as follows:
* Linux, master.
* Disk_out_ref.exo, all vars on, apply.
* Color by temp. Change range to [0,913] or [-1,913]. Edit Color Map. Use log scale when mapping data to colors.
* Works correctly.
* Now, without turning log scaling off, change range to [0,913] or [-1,913].
* Works incorrectly (i.e., range is now [1, 913].
(0033841)
Alan Scott   
2014-11-24 21:59   
See failure note above.
(0033863)
Utkarsh Ayachit   
2014-11-27 13:03   
commit 21b340fbf9ab572ace819ff8637dd8a638e24cff
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Nov 27 13:01:41 2014 -0500

    BUG 0014835: Rescale custom range as needed when using log.

    When log scaling is enabled on the color map, if user specifies a custom
    range that is invalid, use the same range scaling logic as when toggling
    to use log-scale as described in the bug report for BUG 0014835.

    Change-Id: Idbfe340d2635f5e2a88e30e88eed62edbdd999be
(0033864)
Utkarsh Ayachit   
2014-11-28 08:36   
Topics merged into master (v4.2.0-155-gc790012):
        14835_fix_log_scale_for_coloring
(0033869)
Alan Scott   
2014-12-02 15:47   
Perfect.

Tested remote server, master, Linux.