MantisBT - VTK
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0004725	VTK	(No Category)	public	2007-03-29 21:38	2014-09-09 00:04

Reporter	Cory Quammen
Assigned To	Cory Quammen
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS		OS Version
Product Version
Target Version		Fixed in Version
Project
Type

Summary	0004725: vtkXMLShader.cxx places string terminator in incorrect position when reading shaders from files
Description	Under Windows with Microsoft Visual C++, vtkXMLShader places the string terminator '\0' in the incorrect place if CRLF line endings are used. Apparently, the ifstream.read() function converts two-byte CRLF line endings into a single-byte line ending. Thus, in the current code, the string terminator is placed beyond the end of the shader code, effectively leaving undefined character values in the shader code which causes the shader compiler to fail. I have attached a path file for a fix to this problem that places the string terminator in the correct position.
Steps To Reproduce
Additional Information
Tags	No tags attached.
Relationships
Attached Files	vtkXMLShader.cxx.patch (1,008) 1969-12-31 19:00 https://www.vtk.org/Bug/file/5965/vtkXMLShader.cxx.patch

Issue History
Date Modified	Username	Field	Change
2008-02-06 10:05	Jeff Baumes	Assigned To	Will Schroeder => Utkarsh Ayachit
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)
2012-06-11 23:59	Cory Quammen	Note Added: 0028689
2014-09-09 00:04	Cory Quammen	Assigned To	Utkarsh Ayachit => Cory Quammen
2014-09-09 00:04	Cory Quammen	Status	expired => backlog
2014-09-09 00:04	Cory Quammen	Resolution	open => reopened
2014-09-09 00:04	Cory Quammen	Status	backlog => closed
2014-09-09 00:04	Cory Quammen	Resolution	reopened => fixed

Notes