MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007023ParaView(No Category)public2008-05-14 16:292011-02-11 21:42
ReporterOrion Poplawski 
Assigned ToJohn Biddiscombe 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version3.8.1 
Project
Topic Name
Type
Summary0007023: Support HDF5 1.8.0
DescriptionThe attached patch should add support for HDF5 1.8.0
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch paraview-3.2.1-hdf5.patch (847) 2008-05-14 16:29
https://www.vtk.org/Bug/file/6464/paraview-3.2.1-hdf5.patch
patch paraview-3.2.2-hdf5-1.8.patch (2,023) 2008-07-16 13:49
https://www.vtk.org/Bug/file/6601/paraview-3.2.2-hdf5-1.8.patch
patch paraview-3.4.0-hdf5-1.8.2.patch (3,031) 2009-02-26 14:03
https://www.vtk.org/Bug/file/7080/paraview-3.4.0-hdf5-1.8.2.patch
Issue History
Date ModifiedUsernameFieldChange
2008-05-14 16:29Orion PoplawskiNew Issue
2008-05-14 16:29Orion PoplawskiFile Added: paraview-3.2.1-hdf5.patch
2008-06-26 18:31Orion E. PoplawskiNote Added: 0012548
2008-07-04 09:35John BiddiscombeStatusbacklog => tabled
2008-07-04 09:35John BiddiscombeAssigned To => John Biddiscombe
2008-07-04 10:16John BiddiscombeNote Added: 0012624
2008-07-15 19:17Orion E. PoplawskiNote Added: 0012717
2008-07-16 13:48Orion E. PoplawskiNote Added: 0012725
2008-07-16 13:49Orion E. PoplawskiFile Added: paraview-3.2.2-hdf5-1.8.patch
2009-02-26 14:02Orion E. PoplawskiNote Added: 0015431
2009-02-26 14:03Orion E. PoplawskiFile Added: paraview-3.4.0-hdf5-1.8.2.patch
2010-09-20 17:58Orion PoplawskiNote Added: 0022285
2011-01-26 09:26David PartykaNote Added: 0025084
2011-01-26 09:26David PartykaStatustabled => @80@
2011-01-26 09:26David PartykaFixed in Version => 3.8.1
2011-01-26 09:26David PartykaResolutionopen => fixed
2011-02-11 21:42Alan ScottNote Added: 0025411
2011-02-11 21:42Alan ScottStatus@80@ => closed
2011-06-16 13:10Zack GalbreathCategory => (No Category)

Notes
(0012548)
Orion E. Poplawski   
2008-06-26 18:31   
Also:

--- ParaView3.2.1/Utilities/Xdmf2/libsrc/XdmfH5Driver.h.hdf5 2007-11-07 13:51:40.000000000 -0700
+++ ParaView3.2.1/Utilities/Xdmf2/libsrc/XdmfH5Driver.h 2008-06-26 16:31:16.000000000 -0600
@@ -27,7 +27,7 @@
 #include "XdmfDsmBuffer.h"

 #include "H5Ipublic.h"
-#include "H5pubconf.h"
+#include "H5public.h"

 #include "XdmfExport.h"


From the notes in H5public.h:

/* Include files for public use... */
/*
 * Since H5pubconf.h is a generated header file, it is messy to try
 * to put a #ifndef _H5pubconf_H ... #endif guard in it.
 * HDF5 has set an internal rule that it is being included here.
 * Source files should NOT include H5pubconf.h directly but include
 * it via H5public.h. The #ifndef _H5public_H guard above would
 * prevent repeated include.
 */
#include "H5pubconf.h" /*from configure */


This also helps because the Fedora HDF5 packages rename H5pubconf.h to allow for multi-arch installs.
(0012624)
John Biddiscombe   
2008-07-04 10:16   
I've committed the path because it's ok, but I still have other errors, so I'm adding
ADD_DEFINITIONS(-DH5_USE_16_API)
to the xdmf cmakelists. This get's my compilation working for now with hdf 1.8.1
(0012717)
Orion E. Poplawski   
2008-07-15 19:17   
Yeah, I use -DH5_USE_16_API as well. Thanks for the fix.
(0012725)
Orion E. Poplawski   
2008-07-16 13:48   
Some more changes are needed when building an mpi version. I'll attach a patch.
(0015431)
Orion E. Poplawski   
2009-02-26 14:02   
Updated patch to support HDF 1.8.2
(0022285)
Orion Poplawski   
2010-09-20 17:58   
Utilities/Xdmf2/libsrc/XdmfH5Driver.h still includes H5pubconf.h instead of H5public.h.
(0025084)
David Partyka   
2011-01-26 09:26   
ParaView 3.8.1 shipped with HDF5 1.8.5 (though we missed enabling hdf5+zlib compression, which is also addressed). The Utilities/Xdmf2/libsrc/XdmfH5Driver.h has been addressed.
(0025411)
Alan Scott   
2011-02-11 21:42   
Agreed.