MantisBT - VTK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007197VTK(No Category)public2008-06-17 14:292016-08-12 09:54
ReporterDominik Szczerba 
Assigned ToBerk Geveci 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Project
Type
Summary0007197: wrong comparison between doubles throughout the code
Descriptionif(x==y) for x,y floating point should be replaced by

if(fabs(x-y)<eps)

I belive this is the reason the stream tracer filter fails when compiled with the Intel compiler (10.1 on linux OpenSuse 32bit), which is more strict on comparing floating point numbers.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-06-17 14:29Dominik SzczerbaNew Issue
2008-06-17 14:32Dominik SzczerbaNote Added: 0012374
2008-06-17 14:54Sean McBrideNote Added: 0012377
2008-06-24 14:51Berk GeveciStatusbacklog => tabled
2008-06-24 14:51Berk GeveciAssigned To => Berk Geveci
2011-06-16 13:11Zack GalbreathCategory => (No Category)
2016-08-12 09:54Kitware RobotNote Added: 0036990
2016-08-12 09:54Kitware RobotStatusexpired => closed
2016-08-12 09:54Kitware RobotResolutionopen => moved

Notes
(0012374)
Dominik Szczerba   
2008-06-17 14:32   
see mailing list thread: "streamline tracer does not work on cut filter results"
(0012377)
Sean McBride   
2008-06-17 14:54   
gcc is able to generate a warning when floats or doubles are compared with ==. Indeed, VTK has many many such warnings.

There are several fixes and if(fabs(x-y)<eps) is one of them not not necessarily the best approach in all cases.
(0036990)
Kitware Robot   
2016-08-12 09:54   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.