[vtk-developers] Patch for vtkPythonUtil.cxx

[David Cole]

These (and others) are now merged to VTK-5-2 :
    /cvsroot/VTK/VTK/Common/vtkPythonUtil.cxx,v  <--
 Common/vtkPythonUtil.cxx
    new revision: 1.83.2.2; previous revision: 1.83.2.1
    /cvsroot/VTK/VTK/Common/Testing/Python/CMakeLists.txt,v  <--
 Common/Testing/Python/CMakeLists.txt
    new revision: 1.4.2.1; previous revision: 1.4

 /cvsroot/VTK/VTK/Common/Testing/Python/TestExecuteMethodFinalizeCrash.py,v
 <--  Common/Testing/Python/TestExecuteMethodFinalizeCrash.py
    new revision: 1.1.2.2; previous revision: 1.1.2.1
    /cvsroot/VTK/VTK/Common/Testing/Python/TestTerminationCrash.py,v  <--
 Common/Testing/Python/TestTerminationCrash.py
    new revision: 1.2.2.2; previous revision: 1.2.2.1
    /cvsroot/VTK/VTK/Widgets/vtkAffineRepresentation2D.cxx,v  <--
 Widgets/vtkAffineRepresentation2D.cxx
    new revision: 1.6.32.2; previous revision: 1.6.32.1
    /cvsroot/VTK/VTK/Widgets/vtkBalloonRepresentation.cxx,v  <--
 Widgets/vtkBalloonRepresentation.cxx
    new revision: 1.8.32.2; previous revision: 1.8.32.1
    /cvsroot/VTK/VTK/Widgets/vtkCenteredSliderRepresentation.h,v  <--
 Widgets/vtkCenteredSliderRepresentation.h
    new revision: 1.3.2.3; previous revision: 1.3.2.2
    /cvsroot/VTK/VTK/Widgets/vtkContinuousValueWidgetRepresentation.h,v  <--
 Widgets/vtkContinuousValueWidgetRepresentation.h
    new revision: 1.2.2.3; previous revision: 1.2.2.2
    /cvsroot/VTK/VTK/Widgets/vtkImplicitPlaneRepresentation.cxx,v  <--
 Widgets/vtkImplicitPlaneRepresentation.cxx
    new revision: 1.9.2.2; previous revision: 1.9.2.1
    /cvsroot/VTK/VTK/Widgets/vtkScalarBarRepresentation.h,v  <--
 Widgets/vtkScalarBarRepresentation.h
    new revision: 1.1.2.1; previous revision: 1.1
    /cvsroot/VTK/VTK/Widgets/vtkScalarBarRepresentation.cxx,v  <--
 Widgets/vtkScalarBarRepresentation.cxx
    new revision: 1.1.2.1; previous revision: 1.1
    /cvsroot/VTK/VTK/Widgets/vtkSliderRepresentation2D.h,v  <--
 Widgets/vtkSliderRepresentation2D.h
    new revision: 1.2.50.1; previous revision: 1.2
    /cvsroot/VTK/VTK/Widgets/vtkSliderRepresentation2D.cxx,v  <--
 Widgets/vtkSliderRepresentation2D.cxx
    new revision: 1.6.48.2; previous revision: 1.6.48.1
    /cvsroot/VTK/VTK/Widgets/vtkSliderRepresentation3D.h,v  <--
 Widgets/vtkSliderRepresentation3D.h
    new revision: 1.7.14.1; previous revision: 1.7
    /cvsroot/VTK/VTK/Wrapping/Python/vtk/util/numpy_support.py,v  <--
 Wrapping/Python/vtk/util/numpy_support.py
    new revision: 1.2.2.1; previous revision: 1.2


Thanks for your patience,
David


On Wed, Aug 6, 2008 at 4:25 PM, Prabhu Ramachandran
<prabhu at aero.iitb.ac.in>wrote:

> Chris Kruszynski wrote:
>
>> On 05-08-08 19:49, Prabhu Ramachandran wrote:
>> I have dug deeper into why the crashes occur while they shouldn't, and I
>> have uncovered the cause: the vtkPythonHash is deleted from
>> vtkPythonHashDelete(), which is a Py_AtExit callback. The documentation for
>> Py_AtExit is very clear:
>>
>
> Excellent!  I noticed the Py_AtExit but did not realize the problem was
> there.  I've checked in your patch with the test case as well.  Many thanks!
>
> /cvsroot/VTK/VTK/Common/vtkPythonUtil.cxx,v  <--  Common/vtkPythonUtil.cxx
> new revision: 1.90; previous revision: 1.89
> /cvsroot/VTK/VTK/Common/Testing/Python/CMakeLists.txt,v  <--
> Common/Testing/Python/CMakeLists.txt
> new revision: 1.6; previous revision: 1.5
> /cvsroot/VTK/VTK/Common/Testing/Python/TestExecuteMethodFinalizeCrash.py,v
>  <--  Common/Testing/Python/TestExecuteMethodFinalizeCrash.py
> initial revision: 1.1
>
>
> I hope there is time to include these in the 5.2 release.  Thanks!
>
>
>
> cheers,
> prabhu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20080812/db13ae01/attachment.html>