[vtk-developers] Issue with Modifieds in vtkInformation*Key

[Moreland, Kenneth]

OK.  I made the change last night, waited to make sure it still passed all the nightly builds, and then checked them in this morning.  Hopefully nothing will get screwed up.

-Ken

________________________________
From: John Biddiscombe [mailto:biddisco at cscs.ch]
Sent: Friday, July 11, 2008 1:19 AM
To: David Cole; Moreland, Kenneth
Subject: Re: [vtk-developers] Issue with Modifieds in vtkInformation*Key

Ken

I'll be very glad if you fix this. One big problem, is the TIME_XXX values being set/reset making updates happen much too frequently. Fixing the information key modified will be a great relief.

JB


Go for it. That's a nightmare waiting to happen unless I'm totally missing the boat on something...

Modified should only be called if something *actually was modified*.


Thanks,
David

On Thu, Jul 10, 2008 at 5:40 PM, Moreland, Kenneth <kmorel at sandia.gov<mailto:kmorel at sandia.gov>> wrote:
I have discovered that just about every time you call vtkInformation::Set, the vtkInformation object is Modified even when the actual value of the key stays the same.  That should not be the case, should it?  All of the vtkSet* macros avoid calling Modified if the value does not really change.  The problem is that I see in ParaView there are several instances of observes attached to information objects designed to push updated values from client to server.

Does anyone object to me changing the vtkInformation*Key::Set methods to suppress calling Modified when the value remains the same?

-Ken

  ****      Kenneth Moreland
   ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov<mailto:kmorel at sandia.gov>
**  ***  **  phone: (505) 844-8919
   ***      fax:   (505) 845-0833


_______________________________________________
vtk-developers mailing list
vtk-developers at vtk.org<mailto:vtk-developers at vtk.org>
http://www.vtk.org/mailman/listinfo/vtk-developers








________________________________






_______________________________________________

vtk-developers mailing list

vtk-developers at vtk.org<mailto:vtk-developers at vtk.org>

http://www.vtk.org/mailman/listinfo/vtk-developers






--

John Biddiscombe,                            email:biddisco @ cscs.ch

http://www.cscs.ch/about/BJohn.php

CSCS, Swiss National Supercomputing Centre  | Tel:  +41 (91) 610.82.07

Via Cantonale, 6928 Manno, Switzerland      | Fax:  +41 (91) 610.82.82
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20080711/8a8f5393/attachment.html>