[vtk-developers] Fix vtk_exodus2_mangle.h now please

[Fabian, Nathan]

Hi Francois,

It looks like the problem is that the dependencies aren't causing vtkExodusIIReader.cxx to recompile as it should.  Although I noticed this when I compiled it myself, when I compiled after touching the timestamp on Exodus Reader it compiled fine.

The dependency graph is unfortunately non-trivial.  The exodus reader includes exodusII.h (under VTK/Utilities/vtkexodus2/include) which includes vtk_exodus2_mangle.h in the same location.

I made the apparently incorrect assumption that the continuous was doing incremental builds whereas the nightlies would be complete rebuilds.

What is the best way to handle this?  Should I commit an empty change (or add a newline to the end of the file) to vtkExodusIIReader.cxx to update the timestamps on the dashboards?

Thanks,
Nathan.

On 7/21/09 5:07 PM, "Francois Bertel" <francois.bertel at kitware.com> wrote:

I reverted back the change:

http://public.kitware.com/cgi-bin/viewcvs.cgi/VTK/Utilities/vtkexodus2/include/vtk_exodus2_mangle.h?root=ParaView3&view=log

Please compile before you commit, and look at the dashboards once you
commit a file...


On Tue, Jul 21, 2009 at 6:33 PM, Francois
Bertel<francois.bertel at kitware.com> wrote:
> become dead red...
>
> On Tue, Jul 21, 2009 at 6:33 PM, Francois
> Bertel<francois.bertel at kitware.com> wrote:
>> Hello,
>>
>> For the developer with login "ndfabia",
>>
>> You have  less than 1 hour and 30 minutes to revert back or fix your
>> change on  vtk_exodus2_mangle.h before the nightly builds of VTK and
>> ParaView becomes dead read (the nighlty time is 9:00pm edt).
>>
>> Thank you.
>>
>>
>> --
>> François Bertel, PhD  | Kitware Inc. Suite 204
>> 1 (518) 371 3971 x113 | 28 Corporate Drive
>>                      | Clifton Park NY 12065, USA
>>
>
>
>
> --
> François Bertel, PhD  | Kitware Inc. Suite 204
> 1 (518) 371 3971 x113 | 28 Corporate Drive
>                      | Clifton Park NY 12065, USA
>



--
François Bertel, PhD  | Kitware Inc. Suite 204
1 (518) 371 3971 x113 | 28 Corporate Drive
                      | Clifton Park NY 12065, USA
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20090721/0db10457/attachment.html>