[vtk-developers] Building VTK 5.4.2 w/ Tcl/Tk 8.6 -- still getting errors?

[David Cole]

On Wed, Jun 9, 2010 at 12:19 PM, kent williams <nkwmailinglists at gmail.com>wrote:

> So really the test would have to be something like
>
> #if ((TCL_MAJOR_VERSION == 8) && (TCL_MINOR_VERSION > 5)) ||
> (TCL_MAJOR_VERSION > 8)
>
> I wonder about this test later on in vtkTclCommand::Execute as well:
>
> #if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION <= 2
>  res = Tcl_GlobalEval(this->Interp, this->StringCommand);
> #else
>  res = Tcl_EvalEx(this->Interp, this->StringCommand, -1, TCL_EVAL_GLOBAL);
> #endif
>
> Should I log this as a bug and suggest a patch?
>

Sounds like a good plan.....



>
>
> On Wed, Jun 9, 2010 at 11:12 AM, David Cole <david.cole at kitware.com>
> wrote:
> > This is the file in VTK v5.6.0 :
> >
> >
> http://www.vtk.org/gitweb?p=VTK.git;a=blob;f=Common/vtkTclUtil.cxx;h=65cc6d9802e520564a0f5bb2d061ace8d2de0929;hb=0c2379496f8eb1767698c9eade4b656c8649ac2f
> >
> > So, no, it does not contain those changes in 5.6.0 either. And even with
> > those changes, it won't work when Tcl goes to major version 9... The
> #ifdef
> > goes to the "old way" if TCL_MAJOR_VERSION is non-8...
> >
> >
> >
> >
> > On Wed, Jun 9, 2010 at 12:04 PM, kent williams <
> nkwmailinglists at gmail.com>
> > wrote:
> >>
> >> According to this bug report, you should be able to build VTK 5.4.2
> >> with Tcl/Tk 8.6b1:
> >>
> >> http://public.kitware.com/Bug/view.php?id=7822
> >>
> >> But I had to edit one file:
> >>
> >> ===================================================================
> >> RCS file: /cvsroot/VTK/VTK/Common/vtkTclUtil.cxx,v
> >> retrieving revision 1.95
> >> diff -r1.95 vtkTclUtil.cxx
> >> 31a32,36
> >> > #if (TCL_MAJOR_VERSION == 8) && (TCL_MINOR_VERSION >= 6)
> >> > #define TCL_ERROR_LINE(m) (Tcl_GetErrorLine(m))
> >> > #else
> >> > #define TCL_ERROR_LINE(m) (m->errorLine)
> >> > #endif
> >> 493c498
> >> <                              " at line number " <<
> >> arg2->interp->errorLine);
> >> ---
> >> >                              " at line number " <<
> >> > TCL_ERROR_LINE(arg2->interp));
> >> 499c504
> >> <                              " at line number " <<
> >> arg2->interp->errorLine);
> >> ---
> >> >                              " at line number " <<
> >> > TCL_ERROR_LINE(arg2->interp));
> >> 726c731
> >> <                              " at line number " <<
> >> this->Interp->errorLine);
> >> ---
> >> >                              " at line number " <<
> >> > TCL_ERROR_LINE(this->Interp));
> >> 733c738
> >> <                              this->Interp->errorLine);
> >> ---
> >> >                              TCL_ERROR_LINE(this->Interp));
> >>
> >> Is this fixed in vtk 5.6.0?
> >> _______________________________________________
> >> Powered by www.kitware.com
> >>
> >> Visit other Kitware open-source projects at
> >> http://www.kitware.com/opensource/opensource.html
> >>
> >> Follow this link to subscribe/unsubscribe:
> >> http://www.vtk.org/mailman/listinfo/vtk-developers
> >>
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.vtk.org/pipermail/vtk-developers/attachments/20100609/d3f7da6b/attachment.htm>