[vtk-developers] New function: vtkMath::ProjectVector

[John Platt]

Hi David,

There could be a quick exit when b[3] is a zero vector to avoid any trouble computing scale.

There is the potential for round off damage and a small inefficiency by squaring the square root computed by Norm().

I can't get {25./26., 5./26., 0} to make (1.2, -1.6, 0) in your test program.

HTH

John.
  ----- Original Message ----- 
  From: David Cole 
  To: David Doria 
  Cc: VTK Developers 
  Sent: Sunday, September 12, 2010 4:28 PM
  Subject: Re: [vtk-developers] New function: vtkMath::ProjectVector


  On Sun, Sep 12, 2010 at 11:15 AM, David Doria <daviddoria+vtk at gmail.com> wrote:

    On Sun, Sep 12, 2010 at 10:40 AM, David Cole <david.cole at kitware.com> wrote:
    > If it's only one commit, send a link exactly to that commit, so people can
    > click on it and see the diffs right in their web browser:
    > http://github.com/daviddoria/daviddoria-vtk/commit/43efaf1bc09bd8c21e9d15c9366b86b83288f99a
    > If it's a series of commits, be sure you ask for people to look at "the last
    > N commits" or whatever is appropriate.
    > I'll let the math experts chime in and review the actual content of the
    > diffs.
    > A review like this would be easier if you would separate out the "white
    > space only" changes into a separate commit, so the people interested in
    > reviewing the actual diff content don't have to wade through the 80% to find
    > the 20%.... :-)
    >
    > David C.


    Two good points David C. I will definitely link directly to a commit
    in the future.

    I didn't intentionally change any whitespace, I guess there are files
    that have not been committed since the hooks were in place? It looks
    my editor removed the trailing whitespace which shouldn't have been
    there in the first place :) Should we make a pass through and 'touch'
    all of the files and commit them so they are all checked against the
    hooks?

    David D.



  The white space thing shouldn't be that much of a problem, even with files that have present "mistakes" in them... The hooks only check *changed* lines, so maybe change your editor so it doesn't always automatically do that.....?


  Any math guys out there to comment on the rest of David D's changes?


  Thx,
  David C.




------------------------------------------------------------------------------


  _______________________________________________
  Powered by www.kitware.com

  Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

  Follow this link to subscribe/unsubscribe:
  http://www.vtk.org/mailman/listinfo/vtk-developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100913/b33e0610/attachment.html>