[vtk-developers] Adding VTKData and VTKLargeData as optional submodules

[Jean-Christophe Fillion-Robin]

Hi Marcus,

Since by default, it seems the ExternalProjects CMake module is doing a
recursive update on sub-modules, how would these VTK sub-modules be
considered as optional in that case ?

See
http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/ExternalProject.cmake;h=bf2892b741e0d5551ecd310c461289a09e214cf6;hb=HEAD#l318

When building project that depends on VTK, we can not assume VTK will be
built with testing enabled.

Instead wouldn't it make more sens to generalize what ITK folks are doing
to make its easy to reuse for other projects ?

Thanks
Jc


On Wed, Mar 6, 2013 at 10:45 AM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> Except for a few developers, don't assume the VTK developers are
> comfortable with git.
>
> That said, if the right way to do it is a ways off and if the current
> situation is causing a lot of trouble and/or confusion,
>
> Go for it.
>
> Bill
>
>
> On Wed, Mar 6, 2013 at 10:29 AM, Marcus D. Hanwell <
> marcus.hanwell at kitware.com> wrote:
>
>> On Wed, Mar 6, 2013 at 10:23 AM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>> > For ITK, we started with submodules for the data and after a few months
>> > abandoned it. We had too many situations where the submodules got
>> screwed up
>> > because a developer did not follow the proper protocol. I can't recall
>> the
>> > details.
>> >
>> > I suggest we keep things as they are until we switch over to a content
>> based
>> > hashing we use in ITK. Which, my the way, works great.
>>
>> We think that may be a ways off, and any reasonable review where you
>> look at CDash at Home would uncover a submodule screw up. I followed the
>> ITK situation, and honestly think it was quite different with a group
>> uncomfortable with git when submodule support was less mature. The
>> separate repositories is also causing issues whenever a baseline needs
>> to be changed.
>>
>> Marcus
>>
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>


-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130306/ca2d8a73/attachment.html>