[vtk-developers] Dashboard

[David Cole]

Also in Sean’s defense: all he did was make some static methods explicitly static... what could go wrong? 😉

 

And: it’s all just the same warnings over and over, with the one silly compiler complaining that nobody would have caught before merging anyhow.

 

And: they’re all fixed already. Tomorrow will be blissful again.

 

 

D

 


From: Sean McBride
Sent: ‎March‎ ‎21‎, ‎2013 ‎11‎:‎10‎ ‎AM
To: Berk Geveci; VTK Developers
Subject: Re: [vtk-developers] Dashboard


On Thu, 21 Mar 2013 09:54:40 -0400, Berk Geveci said:

>I just took a look at the dashboard. Yikes! It looks like some of the
>changes that were attempting to fix errors/warnings caused wide spread
>warnings/errors :-)

Yup.  Sorry about that!!  But in my defence:
  - the gerrit builds were totally green
  - the AIX compiler is wrong
  - it passed peer review
  - many nightly buildbots seem to have stronger warning
    settings vs the gerrit CDash at Home machines

I didn't personally catch it because I was working on fixing instances of one particular warning, so it was the only warning I had turned on. :(

To prevent this in the future:
  - I'll be even more careful.
  - I'll be making a CDash at Home machine with torturous settings
  - we need a Windows gerrit buildbot!
  - we should increase the warnings on the gerrit buildbots


On Thu, 21 Mar 2013 10:24:51 -0400, Kyle Lutz said:

>And Sean, in the future, could you mark me as a reviewer for these
>types of patches.

Will do.  It's hard to know who to add as reviewers.  I usually use git blame, or add a random Dave. :)

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada


_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130321/dcc3d472/attachment.html>