[vtk-developers] Should we halt gerrit merges?
Robert Maynard
robert.maynard at kitware.com
Tue Mar 26 16:24:57 EDT 2013
So the results of the topic are:
========== Rebuild All: 371 succeeded, 0 failed, 0 skipped ==========
that is a Windows 7 x64 VS2010 build with python wrapping enabled and the
default set of modules enabled.
On Tue, Mar 26, 2013 at 3:54 PM, Marcus D. Hanwell <
marcus.hanwell at kitware.com> wrote:
> On Tue, Mar 26, 2013 at 3:11 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> > Can't you try the patch during the day on a failing nightly?
> >
> I asked Rob to try a Windows Python experimental on the topic, it is
> very low risk as we tracked the issue to the wrap hierarchy seeing new
> headers and the patch removes them from the module headers
> (effectively reverting the majority of the part of the patch that
> added more headers to the vtkCommonCore module). It was an unforeseen
> issue, but I think the best path is to merge fixes but will hopefully
> here back from Rob shortly.
>
> I am out of the office, and will probably be in and out tomorrow, are
> you wanting to block merging fixes in too until they are manually run
> on Windows? The two topics are minimal changes to fix the issues we
> saw in the results to the nightly, and without the coverage of the
> nightly dashboards it will be hard to be certain we covered all of the
> corner cases.
>
> Marcus
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
--
Robert Maynard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130326/457fe199/attachment.html>
More information about the vtk-developers
mailing list