[vtk-developers] Should we halt gerrit merges?

[David Gobbi]

On Wed, Mar 27, 2013 at 10:48 AM, Marcus D. Hanwell
<marcus.hanwell at kitware.com> wrote:
> On Wed, Mar 27, 2013 at 11:06 AM, David Gobbi <david.gobbi at gmail.com> wrote:
>> On Wed, Mar 27, 2013 at 8:56 AM, Marcus D. Hanwell
>> <marcus.hanwell at kitware.com> wrote:
>>
>>> The nightly submissions looked good to me, I wonder if we want to
>>> merge the other patch anyway but will defer to you as our wrapping
>>> expert. If not let me know and I can abandon the change. Thanks for
>>> your help in getting this fixed up so quickly.
>>
>> Are you referring to the topic python-restore-commoncore?
>> http://review.source.kitware.com/#/c/10462/
>
> Yes.
>>
>> I'm actually wondering if maybe we should get rid of _HDRS in all of
>> the CMakeLists.txt  and just put all the files in Module_SRCS.  That
>> would help to simplify the CMakeLists.txt files and probably the module
>> macros, too.
>>
> If you want to look into it and the wrappers can cope. I will happily
> review patches, but probably can't devote much time to it in the next
> few weeks. It would be nice to simplify the macros, I will try to
> carve out a little time if there is general agreement on the approach.

It just seems that it would be a nice simplification, especially now that
we are exporting -Headers.cmake instead of -Classes.cmake. I don't
have any time this week, but next week I can patch all of the
CMakeLists.txt (it'll be quick to do) and if everything stays green then
simplifying the module macros would come next.

 - David