<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Feb 26, 2018 at 5:14 AM, Elvis Stansvik <span dir="ltr"><<a href="mailto:elvis.stansvik@orexplore.com" target="_blank">elvis.stansvik@orexplore.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">2018-02-09 16:58 GMT+01:00 Elvis Stansvik <<a href="mailto:elvis.stansvik@orexplore.com">elvis.stansvik@orexplore.com</a>><wbr>:<br>
> 2018-02-09 15:24 GMT+01:00 Cory Quammen <<a href="mailto:cory.quammen@kitware.com">cory.quammen@kitware.com</a>>:<br>
>> Elvis,<br>
>><br>
>> I don't believe there is a reason we can't use the qreal version of<br>
>> devicePixelRatioF(). I think the F may have gotten dropped in a series of<br>
>> commits to improve DPI support.<br>
>><br>
>> A patch would be welcome.<br>
><br>
> Great, I'll take a stab at it.<br>
<br>
</span>Things got in the way, but now there's a WIP MR from me:<br>
<br>
<a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/3973" rel="noreferrer" target="_blank">https://gitlab.kitware.com/<wbr>vtk/vtk/merge_requests/3973</a><br>
<br>
Marcus: I need your advice on<br>
QVTKInteractorAdapter::<wbr>SetDevicePixelRatio(...) (see question in the<br>
MR).<br></blockquote><div><br></div><div>Replied in the MR, but this was a bug we were seeing on macOS at the time. I mentioned it in the commit message, but it would have been helpful to add a comment in the code. I am not sure if that bug is still relevant, we don't do a lot of testing on macOS with the combination of retinal and non-retinal multi-monitor set ups. Maybe that is too niche to worry about too much too? </div></div></div></div>