<div dir="ltr"><div class="gmail_default" style="font-size:small">Sean,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">I think that these are very good changes.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><span> </span>"= default"</span> makes the code more compact and readable.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small"> Also by setting a minimum capacity, reserve() may even improve performance.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Andrew</div><div class="gmail_extra"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---------- Forwarded message ----------<br>From: Sean McBride <<a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a>><br>To: <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>><br>Cc: <br>Bcc: <br>Date: Thu, 22 Mar 2018 11:23:33 -0400<br>Subject: [vtk-developers] Two automatic clang-tidy changes to confirm...<br>Hi all,<br>
<br>
I've been playing with clang-tidy and there's two changes I want to confirm with everyone:<br>
<br>
1) using "= default" on ctors and dtors:<br>
<br>
<<a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/4092/diffs?commit_id=84ec1d5757165643b34c2c1e35e84fe963cb8a14" rel="noreferrer" target="_blank">https://gitlab.kitware.com/<wbr>vtk/vtk/merge_requests/4092/<wbr>diffs?commit_id=<wbr>84ec1d5757165643b34c2c1e35e84f<wbr>e963cb8a14</a>><br>
<br>
2) using reserve() before filling up a vector:<br>
<br>
<<a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/4092/diffs?commit_id=9266d8817c215f6ee588cfe2102a7152c96af3e7" rel="noreferrer" target="_blank">https://gitlab.kitware.com/<wbr>vtk/vtk/merge_requests/4092/<wbr>diffs?commit_id=<wbr>9266d8817c215f6ee588cfe2102a71<wbr>52c96af3e7</a>><br>
<br>
Cheers,<br>
<br>
--<br>
______________________________<wbr>______________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" rel="noreferrer" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
<br>
<br>
<br>
<br>______________________________<wbr>_________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/<wbr>opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=<wbr>vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="https://vtk.org/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">https://vtk.org/mailman/<wbr>listinfo/vtk-developers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">___________________________________________<br>Andrew J. P. Maclean<br><br>___________________________________________</div>
</div></div>