View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012986

VTK

(No Category)

public

2012-03-09 10:47

2014-10-06 11:20

Reporter

Marc Ferland

Assigned To

Ben Boeckel (Kitware)

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

5.8.0

Target Version

Fixed in Version

Summary

0012986: Crash in vtkChartXY::RemovePlot

Description

The following call to RemovePlotInstance crashes because of a NULL pointer dereference in vtkChartXY::RemovePlot():996

#include <vtkChartXY.h>
#include <vtkContextScene.h>
#include <vtkContextView.h>
#include <vtkPlotLine.h>

int main()
{
   vtkChartXY *chart = vtkChartXY::New();
   vtkPlot *line = vtkPlotLine::New();
   chart->AddPlot(line);
   chart->RemovePlotInstance(line);
   line->Delete();
   chart->Delete();
   return EXIT_SUCCESS;
}

I'm attaching a patch that fixes it for me (based on tag v5.8.0).

Tags

No tags attached.

Project

TBD

Type

crash

Attached Files

0001-Check-the-Scene-pointer-before-dereferencing.patch [^] (792 bytes) 2012-03-09 10:47 [Show Content] [Hide Content]

From c8f684b09e72fb24f06a9edcc4224a994bd183ff Mon Sep 17 00:00:00 2001
From: Marc Ferland <ferlandm@sonatest.com>
Date: Fri, 9 Mar 2012 10:44:22 -0500
Subject: [PATCH] Check the Scene pointer before dereferencing.

---
 Charts/vtkChartXY.cxx |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/Charts/vtkChartXY.cxx b/Charts/vtkChartXY.cxx
index f8f7069..06798d9 100644
--- a/Charts/vtkChartXY.cxx
+++ b/Charts/vtkChartXY.cxx
@@ -993,7 +993,10 @@ bool vtkChartXY::RemovePlot(vtkIdType index)
     // Ensure that the bounds are recalculated
     this->PlotTransformValid = false;
     // Mark the scene as dirty
-    this->Scene->SetDirty(true);
+    if (this->Scene)
+      {
+      this->Scene->SetDirty(true);
+      }
     return true;
     }
   else
-- 
1.7.5.4

Relationships

Notes
(0028349) Marcus D. Hanwell (developer) 2012-03-09 13:30	The patch seems reasonable, but I suspect that there are many other places where we assume Scene is set. What are you trying to do here? There is not much a chart does if it is not in a scene. I can add more null checking to the code.

(0028351) Marc Ferland (reporter) 2012-03-09 13:56	I'm working on a small pipeline editor and I noticed that if I deleted a vtkContextView _before_ deleting the vtkChartXY a segfault always happened. The other objects handled by the pipeline editor can be created or deleted in any order, the only exception is this vtkPlot, vtkChartXY relation.

(0028353) Marc Ferland (reporter) 2012-03-09 14:22	Another case is when I clear my pipeline editor (by deleting all objects making the pipeline), since objects are deleted in no particular order a crash sometimes happen.

(0031253) Dave DeMarle (administrator) 2013-07-22 20:02	moving all "tabled" bugs into "backlog" category since "tabled" is no longer used.

(0033484) Ben Boeckel (Kitware) (developer) 2014-10-02 12:55	Fixed on Gerrit http://review.source.kitware.com/#/t/4766 [^] (as well as a few others when I played around with ChartXYZ as well).

(0033597) Ben Boeckel (Kitware) (developer) 2014-10-06 11:20	The branch has been merged.

Issue History
Date Modified	Username	Field	Change
2012-03-09 10:47	Marc Ferland	New Issue
2012-03-09 10:47	Marc Ferland	File Added: 0001-Check-the-Scene-pointer-before-dereferencing.patch
2012-03-09 10:50	Marcus D. Hanwell	Assigned To	=> Marcus D. Hanwell
2012-03-09 10:50	Marcus D. Hanwell	Status	backlog => tabled
2012-03-09 13:30	Marcus D. Hanwell	Note Added: 0028349
2012-03-09 13:56	Marc Ferland	Note Added: 0028351
2012-03-09 14:22	Marc Ferland	Note Added: 0028353
2013-07-22 20:02	Dave DeMarle	Status	tabled => backlog
2013-07-22 20:02	Dave DeMarle	Note Added: 0031253
2014-10-02 11:47	Ben Boeckel (Kitware)	Assigned To	Marcus D. Hanwell => Ben Boeckel (Kitware)
2014-10-02 12:55	Ben Boeckel (Kitware)	Note Added: 0033484
2014-10-02 12:55	Ben Boeckel (Kitware)	Status	backlog => gerrit review
2014-10-06 11:20	Ben Boeckel (Kitware)	Note Added: 0033597
2014-10-06 11:20	Ben Boeckel (Kitware)	Status	gerrit review => closed
2014-10-06 11:20	Ben Boeckel (Kitware)	Resolution	open => fixed