View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013237VTK(No Category)public2012-06-11 19:512015-01-09 14:01
ReporterDale Lukas Peterson 
Assigned ToKyle Lutz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version6.0.0 
Summary0013237: misspelled member function in vtkContourFilter
DescriptionThis method is present in the vtkContourFilter:

void vtkContourFilter::SetOuputPointsPrecision(int precision)

The member name is missing a 't' after the 'u' and before the 'p'. It should be:

void vtkContourFilter::SetOutputPointsPrecision(int precision)

Also, the parameter is of type int, but shouldn't it be of type vtkAlgorithm::DesiredOutputPrecision ?

There is also a misspelling in the Doxygen documentation, explanation is spelled: "explaination".

Finally, on my machine, when I call SetOuputPointsPrecision(vtkAlgorithm::DOUBLE_PRECISION), and then call contours->GetOutput()->Print(std::cout), I get:

vtkPolyData (0x7fe4f0)
  Debug: Off
  Modified Time: 431
  Reference Count: 1
  Registered Events: (none)
  Information: 0x7fca40
  Data Released: False
  Global Release Data: Off
  UpdateTime: 432
  Field Data:
    Debug: Off
    Modified Time: 380
    Reference Count: 1
    Registered Events: (none)
    Number Of Arrays: 0
    Number Of Components: 0
    Number Of Tuples: 0
  Number Of Points: 38708
  Point Data:
    Debug: Off
    Modified Time: 431
    Reference Count: 1
    Registered Events: (none)
    Number Of Arrays: 2
    Array 0 name = scalars
    Array 1 name = Normals
    Number Of Components: 4
    Number Of Tuples: 38708
    Copy Tuple Flags: ( 0 1 1 1 1 1 1 1 )
    Interpolate Flags: ( 0 1 1 1 1 1 1 1 )
    Pass Through Flags: ( 0 1 1 1 1 1 1 1 )
    Scalars:
      Debug: Off
      Modified Time: 425
      Reference Count: 1
      Registered Events: (none)
      Name: scalars
      Data type: float

Which indicates that double is not being used when computing the scalars. So it seems that this member function isn't actually doing what it advertises, unless I am misusing it or misunderstanding the documentation (very possibly the case). I am giving a vtkSampleFunction to vtkContourFilter, and I have called vtkSampleFunction::SetOutputScalarTypeToDouble(). Or perhaps the PrintSelf method isn't properly implemented and the underlying data type is actually correct?



TagsNo tags attached.
ProjectTBD
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0028690)
Kyle Lutz (viewer)
2012-06-12 09:47

 Hi Dale,

Thanks for catching this! I've pushed a topic with the spelling fixes to gerrit and, after review, it should be merged into VTK. The topic can be seen here: http://review.source.kitware.com/#/t/800/ [^]

The method parameter is an int rather than the enum value because currently our wrapper generators (for python, tcl, etc.) don't correctly handle enums. But you're right, and ideally the parameter would be the enum type.

The desired precision only affects the output point coordinates, not any of the scalar data values associated with the data set. This should probably be made more explicit in the method's documentation.

Thanks,
Kyle

 Issue History
Date Modified Username Field Change
2012-06-11 19:51 Dale Lukas Peterson New Issue
2012-06-12 09:17 Kyle Lutz Assigned To => Kyle Lutz
2012-06-12 09:17 Kyle Lutz Status backlog => todo
2012-06-12 09:17 Kyle Lutz Resolution open => fixed
2012-06-12 09:17 Kyle Lutz Status todo => active development
2012-06-12 09:17 Kyle Lutz Resolution fixed => open
2012-06-12 09:47 Kyle Lutz Note Added: 0028690
2012-06-12 09:47 Kyle Lutz Status active development => gatekeeper review
2012-06-12 09:47 Kyle Lutz Resolution open => fixed
2013-07-22 19:42 Dave DeMarle Status gatekeeper review => closed
2013-07-22 19:42 Dave DeMarle Fixed in Version => 6.0.0
2015-01-09 14:01 Kyle Lutz Source_changeset_attached => VTK master b1441223

Copyright © 2000 - 2018 MantisBT Team