(0001746)
Mathieu Malaterre (developer)
2004-11-22 10:00

Anne,

Are you saying I need to apply this patch (*). Rereading your comment it seems you are saying the contrary, which doesn't make sense to me. Is this possible you sent me the dataset that is causing troubles ?

Mathieu
(*)
Index: vtkEnSightGoldReader.cxx
===================================================================
RCS file: /cvsroot/VTK/VTK/IO/vtkEnSightGoldReader.cxx,v
retrieving revision 1.50
diff -u -3 -p -r1.50 vtkEnSightGoldReader.cxx
--- vtkEnSightGoldReader.cxx 19 Oct 2004 19:35:20 -0000 1.50
+++ vtkEnSightGoldReader.cxx 22 Nov 2004 14:58:41 -0000
@@ -1296,7 +1296,7 @@ int vtkEnSightGoldReader::CreateUnstruct
       lineRead = this->ReadNextDataLine(line);
       sscanf(line, " %s", subLine);

- if (isdigit(subLine[0]))
+ if (isdigit(subLine[0]) > 0)
         { // necessary if node ids were listed
         for (i = 0; i < numPts; i++)
           {

(0001751)
mccdo (reporter)
2004-11-22 14:01

In rereading my comment I realize that it wasn't very clear. Sorry about that.

The issue is that I have a dataset in which the first line of the Z coordinates is a negative number. The isdigit test returns false which then causes an error with the translation. If the test could check for both positive an negative numbers that would fix my problems. I added a line in my version of vtk that does atof and then checks to see if it is < 0. My dataset is 300MB.

(0001838)
Mathieu Malaterre (developer)
2004-12-22 23:16

Fixed in CVS, thanks for report.

$ cvs ci -m"BUG: Fix Bug 0001375 - EnSightGoldReader coordinate reader bug" vtkEnSightGoldReader.cxx
/cvsroot/VTK/VTK/IO/vtkEnSightGoldReader.cxx,v <-- vtkEnSightGoldReader.cxx
new revision: 1.51; previous revision: 1.50

Issue History
Date Modified	Username	Field	Change
2010-11-29 17:59	Mathieu Malaterre	Source_changeset_attached	=> VTK master ac570dcf
2011-01-13 17:00		Source_changeset_attached	=> VTK master a2bd8391
2011-01-13 17:00		Source_changeset_attached	=> VTK master 020ef709
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)

Notes
(0001746) Mathieu Malaterre (developer) 2004-11-22 10:00	Anne, Are you saying I need to apply this patch (). Rereading your comment it seems you are saying the contrary, which doesn't make sense to me. Is this possible you sent me the dataset that is causing troubles ? Mathieu () Index: vtkEnSightGoldReader.cxx =================================================================== RCS file: /cvsroot/VTK/VTK/IO/vtkEnSightGoldReader.cxx,v retrieving revision 1.50 diff -u -3 -p -r1.50 vtkEnSightGoldReader.cxx --- vtkEnSightGoldReader.cxx 19 Oct 2004 19:35:20 -0000 1.50 +++ vtkEnSightGoldReader.cxx 22 Nov 2004 14:58:41 -0000 @@ -1296,7 +1296,7 @@ int vtkEnSightGoldReader::CreateUnstruct lineRead = this->ReadNextDataLine(line); sscanf(line, " %s", subLine); - if (isdigit(subLine[0])) + if (isdigit(subLine[0]) > 0) { // necessary if node ids were listed for (i = 0; i < numPts; i++) {

(0001751) mccdo (reporter) 2004-11-22 14:01	In rereading my comment I realize that it wasn't very clear. Sorry about that. The issue is that I have a dataset in which the first line of the Z coordinates is a negative number. The isdigit test returns false which then causes an error with the translation. If the test could check for both positive an negative numbers that would fix my problems. I added a line in my version of vtk that does atof and then checks to see if it is < 0. My dataset is 300MB.

(0001838) Mathieu Malaterre (developer) 2004-12-22 23:16	Fixed in CVS, thanks for report. $ cvs ci -m"BUG: Fix Bug 0001375 - EnSightGoldReader coordinate reader bug" vtkEnSightGoldReader.cxx /cvsroot/VTK/VTK/IO/vtkEnSightGoldReader.cxx,v <-- vtkEnSightGoldReader.cxx new revision: 1.51; previous revision: 1.50

Relationships