View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013864VTK(No Category)public2013-02-07 09:162014-10-02 09:53
ReporterGoodwin Lawlor 
Assigned ToCory Quammen 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version6.0.rc 
Target Version6.1.0Fixed in Version 
Summary0013864: vtkMakeInstantiator not included in UseVTK.cmake in VTK6.0
DescriptionVTK5.x file UseVTK.cmake had

# Import the VTK_LOAD_CMAKE_EXTENSIONS macro.
include(vtkMakeInstantiator)

but this is omitted in 6.0

Projects (like GDCM) that depend on VTK and use macros like VTK_MAKE_INSTANTIATOR3 need the above include... maybe they should do the include themselves?

See http://vtk.markmail.org/search/?q=#query:+page:1+mid:2t44v6463wzpwc6h+state:results [^]
Tagshackaton
ProjectTBD
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0030318)
Jean-Christophe Fillion-Robin (manager)
2013-02-07 09:23

 Hi Goodwin,

Thanks for reporting and identifying the issue.

If possible, would be awesome if you could help us by submitting a patch using Gerrit.

See http://www.vtk.org/Wiki/VTK/Git/Develop [^]

Thanks
Jc
(0030879)
Dave DeMarle (administrator)
2013-06-03 15:03

 duplicate of http://vtk.org/Bug/view.php?id=14082 [^]
(0031053)
Dave DeMarle (administrator)
2013-06-25 13:17

 Modularization automated many of the lower level facilities, which is probably why this was buried.
Does including vtkExternalModuleMacros (includes vtkModuleMacros (includes vtkMakeInstantiator) work in your case?
(0031146)
Orion Poplawski (reporter)
2013-07-19 12:20

 Also, at install time CMake/vtkMakeInstantiator.cmake, CMake/vtkMakeInstantiator.cxx.in, and CMake/vtkMakeInstantiator.h.in are not installed.
(0032078)
Dave DeMarle (administrator)
2013-12-27 22:21

 http://review.source.kitware.com/#/c/13917/ [^]
(0033425)
Cory Quammen (developer)
2014-10-02 09:52

 Comment from Marcus Hanwell on the gerrit review for this topic:

"We tried to cut down on what was auto-included, the instantiator is not built by default with VTK anymore, and we are deprecating it. I think people who want to use it should include it explicitly, and they will need additional logic to check that the functionality is even configured."

GDCM is now explicitly including the instantiator stuff itself.

https://github.com/malaterre/GDCM/blob/master/Utilities/VTK/CMakeLists.txt [^]

The recommended course of action should be include(vtkMakeInstantiator) in their own projects.

 Issue History
Date Modified Username Field Change
2013-02-07 09:16 Goodwin Lawlor New Issue
2013-02-07 09:23 Jean-Christophe Fillion-Robin Note Added: 0030318
2013-06-03 15:03 Dave DeMarle Assigned To => Dave DeMarle
2013-06-03 15:03 Dave DeMarle Priority normal => urgent
2013-06-03 15:03 Dave DeMarle Status backlog => todo
2013-06-03 15:03 Dave DeMarle Product Version => 6.0.rc
2013-06-03 15:03 Dave DeMarle Target Version => 6.0.0
2013-06-03 15:03 Dave DeMarle Note Added: 0030879
2013-06-25 13:17 Dave DeMarle Note Added: 0031053
2013-06-25 13:17 Dave DeMarle Priority urgent => normal
2013-06-25 13:17 Dave DeMarle Status todo => backlog
2013-06-25 13:17 Dave DeMarle Target Version 6.0.0 => 6.1.0
2013-07-19 12:20 Orion Poplawski Note Added: 0031146
2013-12-27 21:47 Dave DeMarle Status backlog => active development
2013-12-27 22:21 Dave DeMarle Note Added: 0032078
2013-12-27 22:21 Dave DeMarle Status active development => gerrit review
2014-09-30 10:53 Dave DeMarle Assigned To Dave DeMarle =>
2014-10-01 12:40 Berk Geveci Tag Attached: hackaton
2014-10-02 09:52 Cory Quammen Note Added: 0033425
2014-10-02 09:53 Cory Quammen Status gerrit review => closed
2014-10-02 09:53 Cory Quammen Assigned To => Cory Quammen
2014-10-02 09:53 Cory Quammen Resolution open => won't fix

Copyright © 2000 - 2018 MantisBT Team