View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015433 | VTK | (No Category) | public | 2015-04-23 05:17 | 2015-05-07 15:13 | ||||
Reporter | ThomasKilgus | ||||||||
Assigned To | David C. Lonie | ||||||||
Priority | high | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0015433: Anti-aliasing is disabled in VTK 6.2.0 | ||||||||
Description | We are using VTK for rendering in our software platform MITK (see mitk.org for more information). Since we switched to VTK 6.2.0 the anti-aliasing is disabled. We tested this on various OS such as: Mac OC, Ubuntu 14.04, Arch Linux and Windows 7. It is disabled everywhere. To reproduce this is a VTK issue, I did the following but just on my Ubuntu 14.04 machine with a Geforce GTX 560 with both Qt5 and Qt4: -Enabled wireframe property in the read STL example. See attached file. -Clone VTK from github -Checkout tag "v6.2.0" -Build VTK and the example -Run the example -> No anti-aliasing of the wireframe surface -Checkout tag "v6.1.0" -Build VTK and the example -Run the example -> Anti-aliasing is enabled again David Lonie reported on the mailing list that on the current dev branch everything runs fine. Was there any recent fix for this issue so we could patch our VTK? | ||||||||
Tags | No tags attached. | ||||||||
Project | TBD | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | ReadSTL.cxx [^] (1,504 bytes) 2015-04-23 05:17 antialiasing.png [^] (40,536 bytes) 2015-04-23 05:18 AntiAliasingOff.png [^] (1,898,018 bytes) 2015-04-23 08:33 | ||||||||
Relationships | |
Relationships |
Notes | |
(0034368) ThomasKilgus (reporter) 2015-04-23 05:19 |
I also attached a screen shot to compare VTK 6.1 and VTK 6.2. |
(0034369) David C. Lonie (developer) 2015-04-23 09:11 |
Just to clarify, I had not tested this on master, I just mentioned that I'd used multisampling recently in a project and it seemed to be working onscreen, though offscreen rendering with OpenGL was broken. I did just run your test case, and I can confirm that MSAA is not working correctly onscreen anymore with the current master branch. |
(0034370) Christoph Kolb (reporter) 2015-04-23 09:50 |
This can also be observed in the RGrid example, assuming that the number of multisamples is 8 by default (which is not the case on mac) Multisampling works after deleting the following two lines: vtkOpenGL.h:22 #define GL_GLEXT_LEGACY vtkXOpenGLRenderWindow.cxx:29 #define GLX_GLXEXT_LEGACY I am sure that this is not a proper fix for that problem, but maybe it helps isolating it. the second line was introduced in this commit: http://www.vtk.org/gitweb?p=VTK.git;a=commit;h=800282f2 [^] |
(0034396) Joachim Pouderoux (developer) 2015-05-06 11:37 edited on: 2015-05-06 11:38 |
Just tested the provided example on Windows64, with VTK 6.3 (master) and the mesh is definitely anti-aliased here. |
(0034397) David C. Lonie (developer) 2015-05-06 14:12 |
Quick update: I can confirm that the workaround fixes the multisampling, but only the GLX_GLXEXT_LEGACY in vtkXOpenGLRenderWindow.cxx needs to be removed. This was added recently as newer OpenGL implementations provide a glxext.h header that uses the GLintptr and GLsizeiptr types, but does not define them. I'm testing out a new workaround that replaces the vtkXOpenGLRenderWindow.cxx:29 #define GLX_GLXEXT_LEGACY with #include "GL/glcorearb.h" as that header defines these types. This is consistent with Joachim's report on windows, as this should only affect systems using vtkXOpengLRenderWindow. The gitlab branch for this issue is at: https://gitlab.kitware.com/vtk/vtk/merge_requests/178 [^] |
(0034398) David C. Lonie (developer) 2015-05-06 14:40 |
Ok, that didn't work. glcorearb isn't available everywhere. I'll try just adding the typedefs to our version of glext.h... |
(0034399) David C. Lonie (developer) 2015-05-06 14:48 |
No go. It gets mangled into a namespace by the parsers and fails to compile with the missing typedef error. |
(0034400) David C. Lonie (developer) 2015-05-06 15:37 |
Tried updating the glext.h, glxext.h, and wglext.h files that ship with VTK, but there is a mess of colliding typedefs. It looks like a preprocessing issue. Since the parsing/mangling of these headers will be going away soon, I'll try just defining the missing typedefs as needed rather than trying to fix up the parser that's going away soon. It works fine locally, testing on buildbot farm now. |
(0034401) David C. Lonie (developer) 2015-05-07 07:18 |
Patch up for review at https://gitlab.kitware.com/vtk/vtk/merge_requests/178. [^] |
(0034402) David C. Lonie (developer) 2015-05-07 15:13 |
Merged into master. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2015-04-23 05:17 | ThomasKilgus | New Issue | |
2015-04-23 05:17 | ThomasKilgus | File Added: ReadSTL.cxx | |
2015-04-23 05:18 | ThomasKilgus | File Added: antialiasing.png | |
2015-04-23 05:19 | ThomasKilgus | Note Added: 0034368 | |
2015-04-23 08:33 | ThomasKilgus | File Added: AntiAliasingOff.png | |
2015-04-23 09:11 | David C. Lonie | Note Added: 0034369 | |
2015-04-23 09:50 | Christoph Kolb | Note Added: 0034370 | |
2015-05-06 10:49 | David C. Lonie | Assigned To | => David C. Lonie |
2015-05-06 10:49 | David C. Lonie | Status | backlog => active development |
2015-05-06 11:37 | Joachim Pouderoux | Note Added: 0034396 | |
2015-05-06 11:38 | Joachim Pouderoux | Note Edited: 0034396 | |
2015-05-06 14:12 | David C. Lonie | Note Added: 0034397 | |
2015-05-06 14:40 | David C. Lonie | Note Added: 0034398 | |
2015-05-06 14:48 | David C. Lonie | Note Added: 0034399 | |
2015-05-06 15:37 | David C. Lonie | Note Added: 0034400 | |
2015-05-07 07:18 | David C. Lonie | Note Added: 0034401 | |
2015-05-07 07:18 | David C. Lonie | Status | active development => gerrit review |
2015-05-07 15:13 | David C. Lonie | Note Added: 0034402 | |
2015-05-07 15:13 | David C. Lonie | Status | gerrit review => closed |
2015-05-07 15:13 | David C. Lonie | Resolution | open => fixed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |