View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012973

VTK

(No Category)

public

2012-03-01 11:57

2012-09-02 09:48

Reporter

David Gobbi

Assigned To

David Gobbi

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

5.8

Target Version

Fixed in Version

Summary

0012973: The vtkMath::Pi() method should return double, not float, in VTK 6.0.

Description

I found 62 classes that call vtkMath::Pi(). Only one of them,
vtkExodusReader, seemed to have a reason for using a single-precision
value. The others should be taking advantage of the extra precision of a double-precision Pi value, but for some reason they aren't calling vtkMath::DoublePi().

Rather than change all these classes so that they call vtkMath::DoublePi(), it makes more sense for vtkMath::Pi() to return a double, and to deprecate vtkMath::DoublePi(). Considering how close VTK 5.10 is to release, it is probably best if this change is delayed until VTK 6.0.

Tags

No tags attached.

Project

Release

Type

incorrect functionality

Attached Files

Relationships

Notes
(0029104) David Gobbi (developer) 2012-09-02 09:48	Fixed by Bill, will be in VTK 6.

Issue History
Date Modified	Username	Field	Change
2012-03-01 11:57	David Gobbi	New Issue
2012-03-01 11:57	David Gobbi	Status	backlog => tabled
2012-03-01 11:57	David Gobbi	Assigned To	=> David Gobbi
2012-09-02 09:48	David Gobbi	Note Added: 0029104
2012-09-02 09:48	David Gobbi	Status	tabled => closed
2012-09-02 09:48	David Gobbi	Resolution	open => fixed