View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003688

VTK

(No Category)

public

2006-08-31 20:01

2016-08-12 09:54

Reporter

Heath Davis

Assigned To

Will Schroeder

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0003688: Segfault when subclassing vtkProp and vtkPropAssembly

Description

When subclassing vtkProp and vtkPropAssembly, rendering and picking are adversely affected by NULL returns from GetMatrix(). Rendering can segfault near line 119 of Filtering/vtkPropAssembly.cxx. Picking can exit early from line 332 of Rendering/vtkPicker.cxx.

     Analysis of the crash shows that the vtkAssemblyPath built for these subclasses contain NULL Matrix entries. Thankfully, the virtual GetMatrix() can be overridden in subclasses of vtkProp and vtkPropAssembly. That only gets you halfway there, though. The base classes still try to insert NULL matricies into the vtkAssemblyPath when built for subclasses.

     Changes are proposed which will cause subclasses to act correctly. Since the base classes have GetMatrix() defined to return NULL, I predict that the following changes will not adversely affect the operation of VTK.

Common/vtkProp.cxx
  Line 72:
    from:
    path->AddNode(this,NULL);
    to:
    path->AddNode(this, this->GetMatrix());
Filtering/vtkPropAssembly.cxx
  Line 313:
    from:
    path->AddNode(this,NULL);
    to:
    path->AddNode(this, this->GetMatrix());
  Line 346:
    from:
    path->AddNode(prop,NULL);
    to:
    path->AddNode(prop, prop->GetMatrix());

Tags

No tags attached.

Project

Type

Attached Files

Relationships

Notes
(0036887) Kitware Robot (administrator) 2016-08-12 09:54	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current VTK Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2011-06-16 13:11	Zack Galbreath	Category	=> (No Category)
2016-08-12 09:54	Kitware Robot	Note Added: 0036887
2016-08-12 09:54	Kitware Robot	Status	expired => closed
2016-08-12 09:54	Kitware Robot	Resolution	open => moved